Date: Mon, 13 Apr 2009 05:57:00 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Zhaolei <zhaolei@cn.fujitsu.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Steven Rostedt <rostedt@goodmis.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Tom Zanussi <tzanussi@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueue
	tracepoints use TRACE_EVENT macro
Message-ID: <20090413035700.GE11652@elte.hu>
References: <49E28D4B.5040802@cn.fujitsu.com> <20090413103639.6DF4.A69D9226@jp.fujitsu.com> <20090413122350.6DFE.A69D9226@jp.fujitsu.com> <49E2B656.1020308@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49E2B656.1020308@cn.fujitsu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 949
Lines: 24


* Zhaolei <zhaolei@cn.fujitsu.com> wrote:

> It it because I use similar format with other TRACE_EVENT 
> definition. Actually, I don't know why we need to add prefix and 
> postfix TABs, and is it necessary to use tab to make alignment for 
> each fields.

The __array() entry is a bit special - i wouldnt worry much about 
it, please ignore the checkpatch warning in this case - or remove 
the prefix tab.

The alignment of the fields are useful visually: all the field names 
are enumerated in a vertical row and are easy to see at a glance. 
The postfix tabs are nice because they move the non-C-syntax closing 
')' out of the line of sight. The prefix tabs are useful for a 
similar reason.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/