From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Zhaolei <zhaolei@cn.fujitsu.com>
Subject: Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueue tracepoints use TRACE_EVENT macro
Cc: kosaki.motohiro@jp.fujitsu.com, Steven Rostedt <rostedt@goodmis.org>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Tom Zanussi <tzanussi@gmail.com>, Ingo Molnar <mingo@elte.hu>,
       linux-kernel@vger.kernel.org
In-Reply-To: <49E2B656.1020308@cn.fujitsu.com>
References: <20090413122350.6DFE.A69D9226@jp.fujitsu.com> <49E2B656.1020308@cn.fujitsu.com>
Message-Id: <20090413125653.6E01.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Date: Mon, 13 Apr 2009 12:57:52 +0900 (JST)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1464
Lines: 44

Hi

> KOSAKI Motohiro wrote:
> >> Hi,
> >>
> >> hehe, I also have similar patch in my local patch queue ;)
> >>
> >>> +TRACE_EVENT(workqueue_insertion,
> >>> +
> >>> +	TP_PROTO(struct task_struct *wq_thread, struct work_struct *work),
> >>> +
> >>> +	TP_ARGS(wq_thread, work),
> >>> +
> >>> +	TP_STRUCT__entry(
> >>> +		__array(	char,			thread_comm,	TASK_COMM_LEN	)
> >>> +		__field(	pid_t,			thread_pid			)
> >>> +		__field(	struct work_struct *,	work				)
> >>> +		__field(	work_func_t,		func				)
> >>> +	),
> > 
> > and, your patch exceed 80 character in many lines.
> > Please use checkpatch.pl script.
> Hello, Kosaki-san
> 
> Thanks for your comments for this patch,
> I'll merge your and other people's comments and send a V2.
> 
> About line exceed 80 characters, I do checkpatch before send, and I know that
> lines in TP_STRUCT__entry are too long.
> It it because I use similar format with other TRACE_EVENT definition.
> Actually, I don't know why we need to add prefix and postfix TABs, and is it
> necessary to use tab to make alignment for each fields.
> Who can give me teach? or I will use different format to fix this 80-char problem.

I'll send my patch today's later. please give me comment :)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/