Message-ID: <7D90907194A540339DD93446AFE09B37@zhaoleiwin>
From: "Zhaolei" <zhaolei@cn.fujitsu.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "KOSAKI Motohiro" <kosaki.motohiro@jp.fujitsu.com>,
       "Steven Rostedt" <rostedt@goodmis.org>,
       "Frederic Weisbecker" <fweisbec@gmail.com>,
       "Tom Zanussi" <tzanussi@gmail.com>, <linux-kernel@vger.kernel.org>
References: <49E28D4B.5040802@cn.fujitsu.com> <20090413103639.6DF4.A69D9226@jp.fujitsu.com> <20090413122350.6DFE.A69D9226@jp.fujitsu.com> <49E2B656.1020308@cn.fujitsu.com> <20090413035700.GE11652@elte.hu>
Subject: Re: Re: [PATCH 1/1] tracing, workqueuetrace: Make workqueuetracepoints use TRACE_EVENT macro
Date: Mon, 13 Apr 2009 12:07:28 +0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="ISO-8859-1"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1158
Lines: 33

* From: "Ingo Molnar" <mingo@elte.hu>
> 
> * Zhaolei <zhaolei@cn.fujitsu.com> wrote:
> 
>> It it because I use similar format with other TRACE_EVENT 
>> definition. Actually, I don't know why we need to add prefix and 
>> postfix TABs, and is it necessary to use tab to make alignment for 
>> each fields.
> 
> The __array() entry is a bit special - i wouldnt worry much about 
> it, please ignore the checkpatch warning in this case - or remove 
> the prefix tab.
Hello, Ingo 

Thanks for your teach.

I think remove the prefix tab only(but remain postfix) make code looks
a bit ugly. I prefer to remain both tabs.
It is to say I will not modify tabs in this patch.

Thanks
Zhaolei

> 
> The alignment of the fields are useful visually: all the field names 
> are enumerated in a vertical row and are easy to see at a glance. 
> The postfix tabs are nice because they move the non-C-syntax closing 
> ')' out of the line of sight. The prefix tabs are useful for a 
> similar reason.
> 
> Ingo
> 
>????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?