Date: Mon, 13 Apr 2009 09:31:01 -0700
From: Greg KH <greg@kroah.com>
To: tom.leiming@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject: kzfree object in _release function
Message-ID: <20090413163101.GD32368@kroah.com>
References: <1239466586-29410-1-git-send-email-tom.leiming@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1239466586-29410-1-git-send-email-tom.leiming@gmail.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1394
Lines: 43

On Sun, Apr 12, 2009 at 12:16:26AM +0800, tom.leiming@gmail.com wrote:
> From: Ming Lei <tom.leiming@gmail.com>
> 
> It helps to troubleshoot the __buggy__ case, in which
> unreferenced objects are still accessed, using kzfree
> to free objects safely in _release function.
> 
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
>  lib/kobject.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/kobject.c b/lib/kobject.c
> index a6dec32..cb5a562 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -597,7 +597,7 @@ void kobject_put(struct kobject *kobj)
>  static void dynamic_kobj_release(struct kobject *kobj)
>  {
>  	pr_debug("kobject: (%p): %s\n", kobj, __func__);
> -	kfree(kobj);
> +	kzfree(kobj);
>  }
>  
>  static struct kobj_type dynamic_kobj_ktype = {
> @@ -762,7 +762,7 @@ static void kset_release(struct kobject *kobj)
>  	struct kset *kset = container_of(kobj, struct kset, kobj);
>  	pr_debug("kobject: '%s' (%p): %s\n",
>  		 kobject_name(kobj), kobj, __func__);
> -	kfree(kset);
> +	kzfree(kset);


What about slab-poisoning?  Shouldn't we just rely on that instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/