Date: Mon, 13 Apr 2009 16:20:42 -0700 (PDT)
Message-Id: <20090413.162042.79456870.davem@davemloft.net>
To: rjw@sisk.pl
Cc: bonbons@linux-vserver.org, romieu@fr.zoreil.com, netdev@vger.kernel.org,
       linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH] NET/r8169: Rework suspend and resume
From: David Miller <davem@davemloft.net>
In-Reply-To: <200904052359.31629.rjw@sisk.pl>
References: <200904052040.04752.rjw@sisk.pl>
	<20090405223318.5a494e4e@neptune.home>
	<200904052359.31629.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1611
Lines: 38

From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Sun, 5 Apr 2009 23:59:31 +0200

> On Sunday 05 April 2009, Bruno Pr?mont wrote:
>> On Sun, 05 April 2009 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>> > From: Rafael J. Wysocki <rjw@sisk.pl>
>> > 
>> > The recent changes of the PCI PM core allow us to simplify the
>> > suspend and resume handling in a number of device drivers, since they
>> > don't need to carry out the general PCI PM operations, such as
>> > changing the power state of the device, during suspend and resume any
>> > more.
>> > 
>> > Simplify the suspend and resume callbacks of r8169 using the
>> > observation that the PCI PM core can take care of some operations
>> > carried out by the driver.
>> > 
>> > Additionally, make the shutdown callback of r8169 only put the device
>> > into a low power state if the system is going to be powered off
>> > (kexec is known to have problems with network adapters that are put
>> > into low power states on shutdown).
>> > 
>> > This patch has been tested on MSI Wind U100.
>> 
>> Tested against 2.6.29.1 on my Commell LE-365 and suspend (S3) + WoL
>> still works as expected.
>> 
>> 02:08.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
>>                      RTL-8169 Gigabit Ethernet [10ec:8169] (rev 10)
> 
> Thanks for testing!

I've applied this patch to net-next-2.6, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/