Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753682AbZDMXXu (ORCPT ); Mon, 13 Apr 2009 19:23:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753285AbZDMXXj (ORCPT ); Mon, 13 Apr 2009 19:23:39 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:59671 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752686AbZDMXXi (ORCPT ); Mon, 13 Apr 2009 19:23:38 -0400 Date: Mon, 13 Apr 2009 16:23:29 -0700 (PDT) Message-Id: <20090413.162329.83864908.davem@davemloft.net> To: mschmidt@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shemminger@vyatta.com Subject: Re: [PATCH] skge: fix occasional BUG during MTU change From: David Miller In-Reply-To: <20090407183623.7545bb0b@leela> References: <20090407183623.7545bb0b@leela> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 25 From: Michal Schmidt Date: Tue, 7 Apr 2009 18:36:23 +0200 > The BUG_ON(skge->tx_ring.to_use != skge->tx_ring.to_clean) in skge_up() > was sometimes observed when setting MTU. > > skge_down() disables the TX queue, but then reenables it by mistake via > skge_tx_clean(). > Fix it by moving the waking of the queue from skge_tx_clean() to the > other caller. And to make sure start_xmit is not in progress on another > CPU, skge_down() should call netif_tx_disable(). > > The bug was reported to me by Jiri Jilek whose Debian system sometimes > failed to boot. He tested the patch and the bug did not happen anymore. > > Signed-off-by: Michal Schmidt Stephen have you had a chance to test this yet? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/