Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbZDNJim (ORCPT ); Tue, 14 Apr 2009 05:38:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751720AbZDNJib (ORCPT ); Tue, 14 Apr 2009 05:38:31 -0400 Received: from gate.crashing.org ([63.228.1.57]:45190 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbZDNJib (ORCPT ); Tue, 14 Apr 2009 05:38:31 -0400 In-Reply-To: <49E39F3D.4060501@twiddle.net> References: <49E39F3D.4060501@twiddle.net> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Cc: Matt Turner , Oliver Falk , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Ivan Kokshaysky , linux-alpha@vger.kernel.org, Jay Estabrook Content-Transfer-Encoding: 7bit From: Segher Boessenkool Subject: Re: alpha: half done futex implementation Date: Tue, 14 Apr 2009 11:40:50 +0200 To: Richard Henderson X-Mailer: Apple Mail (2.753.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 18 > Also, there's a bug in the powerpc implementation. It appears that > oparg is clobbered, and if stwcx fails the operation will be > repeated with incorrect inputs. If either the lwarx or the stwcx. faults, the routine returns -EFAULT and doesn't retry (label "3" is the end of the asm). If the stwcx. fails because the CPU lost the reservation, %1 isn't clobbered as far as I see? Segher -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/