Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756689AbZDNQKW (ORCPT ); Tue, 14 Apr 2009 12:10:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753039AbZDNQKE (ORCPT ); Tue, 14 Apr 2009 12:10:04 -0400 Received: from emulex.emulex.com ([138.239.112.1]:63081 "EHLO emulex.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752032AbZDNQKC (ORCPT ); Tue, 14 Apr 2009 12:10:02 -0400 Message-ID: <49E4B51E.3040402@emulex.com> Date: Tue, 14 Apr 2009 12:09:02 -0400 From: James Smart User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: David Howells CC: "linux-scsi@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Fix lpfc_parse_bg_err()'s use of do_div() References: <20090414155948.27755.2131.stgit@warthog.procyon.org.uk> In-Reply-To: <20090414155948.27755.2131.stgit@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 14 Apr 2009 16:09:03.0997 (UTC) FILETIME=[54B95AD0:01C9BD1B] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1802 Lines: 48 David, I already posted the same fix on 4/7. See: http://marc.info/?l=linux-scsi&m=123912745216961&w=2 -- james s David Howells wrote: > Fix lpfc_parse_bg_err()'s use of do_div(). It should be passing a 64-bit > variable as the first parameter. However, since it's only using a 32-bit > variable, it doesn't need to use do_div() at all, but can instead use the > division operator. > > This deals with the following warnings: > > CC drivers/scsi/lpfc/lpfc_scsi.o > drivers/scsi/lpfc/lpfc_scsi.c: In function 'lpfc_parse_bg_err': > drivers/scsi/lpfc/lpfc_scsi.c:1397: warning: comparison of distinct pointer types lacks a cast > drivers/scsi/lpfc/lpfc_scsi.c:1397: warning: right shift count >= width of type > drivers/scsi/lpfc/lpfc_scsi.c:1397: warning: passing argument 1 of '__div64_32' from incompatible pointer type > > Signed-off-by: David Howells > --- > > drivers/scsi/lpfc/lpfc_scsi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c > index b1bd3fc..36fd2e7 100644 > --- a/drivers/scsi/lpfc/lpfc_scsi.c > +++ b/drivers/scsi/lpfc/lpfc_scsi.c > @@ -1394,7 +1394,7 @@ lpfc_parse_bg_err(struct lpfc_hba *phba, struct lpfc_scsi_buf *lpfc_cmd, > */ > cmd->sense_buffer[8] = 0; /* Information */ > cmd->sense_buffer[9] = 0xa; /* Add. length */ > - do_div(bghm, cmd->device->sector_size); > + bghm /= cmd->device->sector_size; > > failing_sector = scsi_get_lba(cmd); > failing_sector += bghm; > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/