Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757491AbZDNQvU (ORCPT ); Tue, 14 Apr 2009 12:51:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751512AbZDNQvI (ORCPT ); Tue, 14 Apr 2009 12:51:08 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:46349 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbZDNQvF (ORCPT ); Tue, 14 Apr 2009 12:51:05 -0400 Date: Tue, 14 Apr 2009 18:50:52 +0200 From: Ingo Molnar To: Jaswinder Singh Rajput Cc: x86 maintainers , LKML Subject: Re: [PATCH -tip] x86: cpu_debug.c prepare report if files are inappropriate or CPU is not supported Message-ID: <20090414165052.GA2089@elte.hu> References: <1239725240.2966.4.camel@ht.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1239725240.2966.4.camel@ht.satnam> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 29 * Jaswinder Singh Rajput wrote: > + if (!per_cpu(cpu_modelflag, cpu)) hm, on a second look - the whole cpu_model / cpu_modelflag business in arch/x86/kernel/cpu/cpu_debug.c looks over-complicated and broken. You encode it into a 'modelflag': per_cpu(cpu_model, cpu) = ((cpui->x86_vendor << 16) | (cpui->x86 << 8) | (cpui->x86_model)); just to decode it later on: flag = per_cpu(cpu_model, cpu); switch (flag >> 16) { That does not make much sense. Please use a proper boot_cpu_data.x86_vendor switch() statement, ok? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/