Date: Tue, 14 Apr 2009 14:33:12 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
       Thomas Gleixner <tglx@linutronix.de>,
       Peter Zijlstra <peterz@infradead.org>,
       Frederic Weisbecker <fweisbec@gmail.com>, Theodore Tso <tytso@mit.edu>,
       Arjan van de Ven <arjan@infradead.org>, Christoph Hellwig <hch@lst.de>,
       Mathieu Desnoyers <compudj@krystal.dyndns.org>,
       Jeremy Fitzhardinge <jeremy@goop.org>,
       Lai Jiangshan <laijs@cn.fujitsu.com>, Zhaolei <zhaolei@cn.fujitsu.com>,
       Li Zefan <lizf@cn.fujitsu.com>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Masami Hiramatsu <mhiramat@redhat.com>,
       "Frank Ch. Eigler" <fche@elastic.org>, Tom Zanussi <tzanussi@gmail.com>,
       Jiaying Zhang <jiayingz@google.com>, Michael Rubin <mrubin@google.com>,
       Martin Bligh <mbligh@google.com>
Subject: Re: [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules
In-Reply-To: <20090414182100.GB19814@elte.hu>
Message-ID: <alpine.DEB.2.00.0904141431530.31421@gandalf.stny.rr.com>
References: <20090414172337.280621613@goodmis.org> <20090414182100.GB19814@elte.hu>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2040
Lines: 55


On Tue, 14 Apr 2009, Ingo Molnar wrote:

> 
> * Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> >  include/trace/define_trace.h        |   79 ++++++
> >  include/trace/ftrace.h              |  493 +++++++++++++++++++++++++++++++++++
> >  include/trace/irq.h                 |   56 ++++-
> >  include/trace/irq_event_types.h     |   55 ----
> >  include/trace/kmem.h                |  189 +++++++++++++-
> >  include/trace/lockdep.h             |   55 ++++-
> >  include/trace/lockdep_event_types.h |   57 ----
> >  include/trace/sched.h               |  336 +++++++++++++++++++++++-
> >  include/trace/sched_event_types.h   |  337 ------------------------
> >  include/trace/skb.h                 |   39 +++-
> >  include/trace/skb_event_types.h     |   38 ---
> >  include/trace/trace_event_types.h   |    7 -
> >  include/trace/trace_events.h        |    7 -
> 
> Detail: we still have include/trace/kmem_event_types.h around - is 
> that intentional? It isnt actually used by anything so we can git-rm 
> it.

I rebased it several times, doing minor tweaks and such. I think I may 
have missed a git-rm. That file is suppose to be deleted.

> 
> Also, we mix tracepoint definition headers with other misc headers 
> such as syscall.h or boot.h.
> 
> I think it would be cleaner and better sructured to have these 
> centrally enumerated tracepoint definitions separated in 
> include/trace/events/.
> 
> That sub-directory would _only_ include the TRACE_EVENT() 
> definitions - nothing else. Hence it would also be a nice in-situ 
> template collection for anyone adding new tracepoints. The existence 
> of other headers really distracts from that.
> 
> What do you think?

I'm fine with that. As long as people are fine with doing:

#include <trace/events/sched.h>

and such.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/