Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbZDNTay (ORCPT ); Tue, 14 Apr 2009 15:30:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752538AbZDNTan (ORCPT ); Tue, 14 Apr 2009 15:30:43 -0400 Received: from gw1.cosmosbay.com ([212.99.114.194]:51714 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752224AbZDNTam convert rfc822-to-8bit (ORCPT ); Tue, 14 Apr 2009 15:30:42 -0400 Message-ID: <49E4E3E8.5090201@cosmosbay.com> Date: Tue, 14 Apr 2009 21:28:40 +0200 From: Eric Dumazet User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Stephen Hemminger CC: Jeff Chua , Patrick McHardy , paulmck@linux.vnet.ibm.com, David Miller , paulus@samba.org, mingo@elte.hu, torvalds@linux-foundation.org, laijs@cn.fujitsu.com, jengelh@medozas.de, r000n@r000n.net, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, benh@kernel.crashing.org Subject: Re: [PATCH] netfilter: use per-cpu spinlock rather than RCU (v2) References: <20090411174801.GG6822@linux.vnet.ibm.com> <18913.53699.544083.320542@cargo.ozlabs.ibm.com> <20090412173108.GO6822@linux.vnet.ibm.com> <20090412.181330.23529546.davem@davemloft.net> <20090413040413.GQ6822@linux.vnet.ibm.com> <20090413095309.631cf395@nehalam> <49E48136.5060700@trash.net> <49E49C65.8060808@cosmosbay.com> <20090414074554.7fa73e2f@nehalam> <49E4B0A5.70404@cosmosbay.com> <20090414111716.28585806@nehalam> In-Reply-To: <20090414111716.28585806@nehalam> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [0.0.0.0]); Tue, 14 Apr 2009 21:28:42 +0200 (CEST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1708 Lines: 46 Stephen Hemminger a ?crit : > Subject: iptables: > > This is an alternative version of ip/ip6/arp tables locking using > per-cpu locks. This avoids the overhead of synchronize_net() during > update but still removes the expensive rwlock in earlier versions. > > The idea for this came from an earlier version done by Eric Duzamet. > Locking is done per-cpu, the fast path locks on the current cpu > and updates counters. The slow case involves acquiring the locks on > all cpu's. > > The mutex that was added for 2.6.30 in xt_table is unnecessary since > there already is a mutex for xt[af].mutex that is held. > > Signed-off-by: Stephen Hemminger > > --- > include/linux/netfilter/x_tables.h | 5 - > net/ipv4/netfilter/arp_tables.c | 112 +++++++++------------------------ > net/ipv4/netfilter/ip_tables.c | 123 +++++++++++-------------------------- > net/ipv6/netfilter/ip6_tables.c | 119 +++++++++++------------------------ > net/netfilter/x_tables.c | 28 -------- > 5 files changed, 110 insertions(+), 277 deletions(-) Oh well, it seems factorization of this stuff is not what you want, so I'll stop arguing. Please check spelling of my name in ChangeLog, and more importantly : initialize arp_tables_lock that is missing in V1/2 for_each_possible_cpu(cpu) spin_lock_init(&per_cpu(arp_tables_lock, cpu)); Then please add my : Signed-off-by: Eric Dumazet Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/