Subject: Re: [REGRESSION] threaded interrupt handler support breaks (some)
	irq handling on AVR32
From: Ben Nizette <bn@niasdigital.com>
To: tglx@linutronix.de
Cc: David Brownell <david-b@pacbell.net>, hskinnemoen@atmel.com,
       kernel@avr32linux.org, linux-kernel@vger.kernel.org,
       imre.deak@nokia.com, mingo@elte.hu
In-Reply-To: <1239698225.29831.14.camel@linux-51e8.site>
References: <1239685153.19815.12.camel@linux-51e8.site>
	 <1239698225.29831.14.camel@linux-51e8.site>
Content-Type: text/plain
Date: Wed, 15 Apr 2009 11:30:53 +1000
Message-Id: <1239759053.29831.37.camel@linux-51e8.site>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1362
Lines: 45

On Tue, 2009-04-14 at 18:37 +1000, Ben Nizette wrote:

> If no one beats me to it i'll try and scatter printks and narrow down
> exactly *where* it all explodes tomorrow.

static irqreturn_t ads7846_irq(int irq, void *handle)
{
	struct ads7846 *ts = handle;
	unsigned long flags;

	spin_lock_irqsave(&ts->lock, flags);
	if (likely(get_pendown_state(ts))) {
		if (!ts->irq_disabled) {
			/* The ARM do_simple_IRQ() dispatcher doesn't act
			 * like the other dispatchers:  it will report IRQs
			 * even after they've been disabled.  We work around
			 * that here.  (The "generic irq" framework may help...)
			 */
			ts->irq_disabled = 1;
			disable_irq(ts->spi->irq);
			ts->pending = 1;
			hrtimer_start(&ts->timer, ktime_set(0, TS_POLL_DELAY),
					HRTIMER_MODE_REL);
		}
	}
	spin_unlock_irqrestore(&ts->lock, flags);

	return IRQ_HANDLED;
}

Right, a scattering of printks in there shows execution gets at least as
far as inside the inner-most code block.  A printk directly before the
disable_irq() doesn't make it to my console so I'm guessing that the
hang is in there somewhere.

Hope this helps,
	--Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/