Return-Path: <linux-kernel-owner+w=401wt.eu-S1757181AbZDOC0T@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757181AbZDOC0T (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Apr 2009 22:26:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754017AbZDOC0B
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 14 Apr 2009 22:26:01 -0400
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:43799 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753663AbZDOC0A (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Apr 2009 22:26:00 -0400
Date: Tue, 14 Apr 2009 22:25:57 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
X-X-Sender: rostedt@gandalf.stny.rr.com
To: Peter Zijlstra <peterz@infradead.org>
cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
       Andrew Morton <akpm@linux-foundation.org>,
       Thomas Gleixner <tglx@linutronix.de>,
       Frederic Weisbecker <fweisbec@gmail.com>, Theodore Tso <tytso@mit.edu>,
       Arjan van de Ven <arjan@infradead.org>, Christoph Hellwig <hch@lst.de>,
       Mathieu Desnoyers <compudj@krystal.dyndns.org>,
       Jeremy Fitzhardinge <jeremy@goop.org>,
       Lai Jiangshan <laijs@cn.fujitsu.com>, Zhaolei <zhaolei@cn.fujitsu.com>,
       Li Zefan <lizf@cn.fujitsu.com>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Masami Hiramatsu <mhiramat@redhat.com>,
       "Frank Ch. Eigler" <fche@elastic.org>, Tom Zanussi <tzanussi@gmail.com>,
       Jiaying Zhang <jiayingz@google.com>, Michael Rubin <mrubin@google.com>,
       Martin Bligh <mbligh@google.com>
Subject: Re: [PATCH 5/8] tracing/events: move the ftrace event tracing code
 to core
In-Reply-To: <1239736986.22720.266.camel@laptop>
Message-ID: <alpine.DEB.2.00.0904142219570.31421@gandalf.stny.rr.com>
References: <20090414172337.280621613@goodmis.org>  <20090414172641.457760734@goodmis.org> <1239736986.22720.266.camel@laptop>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1456
Lines: 37


On Tue, 14 Apr 2009, Peter Zijlstra wrote:

> On Tue, 2009-04-14 at 13:23 -0400, Steven Rostedt wrote:
> > + * static struct trace_event ftrace_event_type_<call> = {
> > + *     .trace                  = ftrace_raw_output_<call>, <-- stage 2
> > + * };
> 
> > + * static struct ftrace_event_call __used
> > + * __attribute__((__aligned__(4)))
> > + * __attribute__((section("_ftrace_events"))) event_<call> = {
> > + *     .name                   = "<call>",
> > + *     .system                 = "<system>",
> > + *     .raw_init               = ftrace_raw_init_event_<call>,
> > + *     .regfunc                = ftrace_reg_event_<call>,
> > + *     .unregfunc              = ftrace_unreg_event_<call>,
> > + *     .show_format            = ftrace_format_<call>,
> > + * }
> 
> Is there a good reason these are two different structs?
> 
> I've always wondered about that, it seems natural to unify them and to
> generalize the reverse lookup hash that is now private to trace_output.
> 
> The trace_event_profile code could use that reverse lookup, that linear
> search it currently does it really lame.

Hmm, I'll have to look at that. Of course that means touching these crazy 
macros again ;-)

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/