Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759280AbZDOIeB (ORCPT ); Wed, 15 Apr 2009 04:34:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759170AbZDOIdf (ORCPT ); Wed, 15 Apr 2009 04:33:35 -0400 Received: from mailbox-us-s-12.mailhostingserver.com ([75.125.101.9]:50195 "EHLO mailbox-us-s-12.mailhostingserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758854AbZDOIdc (ORCPT ); Wed, 15 Apr 2009 04:33:32 -0400 Date: Wed, 15 Apr 2009 10:33:26 +0200 From: Matthias Kaehlcke To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, Bill Gatliff Subject: re: Linux 2.6.30-rc2: [PATCH] ARM OABI compatibility: fix build error Message-ID: <20090415083326.GA12921@traven> Mail-Followup-To: Matthias Kaehlcke , Linus Torvalds , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, Bill Gatliff References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2010 Lines: 56 Building for ARM with CONFIG_OABI_COMPAT enabled fails due to a missing include: arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait': arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of function 'kmalloc' arch/arm/kernel/sys_oabi-compat.c:288: error: 'GFP_KERNEL' undeclared (first use in this function) arch/arm/kernel/sys_oabi-compat.c:288: error: (Each undeclared identifier is reported only once arch/arm/kernel/sys_oabi-compat.c:288: error: for each function it appears in.) arch/arm/kernel/sys_oabi-compat.c:288: warning: assignment makes pointer from integer without a cast arch/arm/kernel/sys_oabi-compat.c:301: error: implicit declaration of function 'kfree' arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop': arch/arm/kernel/sys_oabi-compat.c:324: error: 'GFP_KERNEL' undeclared (first use in this function) arch/arm/kernel/sys_oabi-compat.c:324: warning: assignment makes pointer from integer without a cast make[1]: *** [arch/arm/kernel/sys_oabi-compat.o] Error 1 make: *** [arch/arm/kernel] Error 2 including linux/mm.h fixes this (thanks to Bill Gatliff for the pointer) -- ARM: Fix build error when CONFIG_OABI_COMPAT is selected Signed-off-by: Matthias Kaehlcke --- arch/arm/kernel/sys_oabi-compat.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/kernel/sys_oabi-compat.c b/arch/arm/kernel/sys_oabi-compat.c index 42623db..5d666ac 100644 --- a/arch/arm/kernel/sys_oabi-compat.c +++ b/arch/arm/kernel/sys_oabi-compat.c @@ -80,6 +80,7 @@ #include #include #include +#include #include #include #include -- 1.6.2.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/