Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759567AbZDOKP3 (ORCPT ); Wed, 15 Apr 2009 06:15:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759414AbZDOKON (ORCPT ); Wed, 15 Apr 2009 06:14:13 -0400 Received: from stinky.trash.net ([213.144.137.162]:55506 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759384AbZDOKOJ (ORCPT ); Wed, 15 Apr 2009 06:14:09 -0400 Message-ID: <49E5B365.2010008@trash.net> Date: Wed, 15 Apr 2009 12:13:57 +0200 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: David Miller CC: dada1@cosmosbay.com, jpirko@redhat.com, lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com, shemminger@linux-foundation.org, bridge@lists.linux-foundation.org, fubar@us.ibm.com, bonding-devel@lists.sourceforge.net, mschmidt@redhat.com, ivecera@redhat.com Subject: Re: [PATCH 1/3] net: introduce a list of device addresses dev_addr_list References: <49E59A1C.9030108@cn.fujitsu.com> <20090415083223.GF21342@psychotron.englab.brq.redhat.com> <49E5A896.90408@cosmosbay.com> <20090415.023104.82135803.davem@davemloft.net> In-Reply-To: <20090415.023104.82135803.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 655 Lines: 18 David Miller wrote: > From: Eric Dumazet > Date: Wed, 15 Apr 2009 11:27:50 +0200 > >> Since you obviously need a write lock here to be sure following >> can be done by one cpu only. >> >> You have same problem all over this patch. > > RTNL semaphore is held across all modification operations. If this will also be used for multicast lists, changes can happen (IPv6) without the RTNL. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/