Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbZDOK7e (ORCPT ); Wed, 15 Apr 2009 06:59:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753172AbZDOK7U (ORCPT ); Wed, 15 Apr 2009 06:59:20 -0400 Received: from stinky.trash.net ([213.144.137.162]:56508 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751016AbZDOK7T (ORCPT ); Wed, 15 Apr 2009 06:59:19 -0400 Message-ID: <49E5BDF7.8090502@trash.net> Date: Wed, 15 Apr 2009 12:59:03 +0200 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Eric Dumazet CC: Stephen Hemminger , Jeff Chua , paulmck@linux.vnet.ibm.com, David Miller , paulus@samba.org, mingo@elte.hu, torvalds@linux-foundation.org, laijs@cn.fujitsu.com, jengelh@medozas.de, r000n@r000n.net, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, benh@kernel.crashing.org Subject: Re: [PATCH] netfilter: use per-cpu spinlock rather than RCU (v3) References: <20090411174801.GG6822@linux.vnet.ibm.com> <18913.53699.544083.320542@cargo.ozlabs.ibm.com> <20090412173108.GO6822@linux.vnet.ibm.com> <20090412.181330.23529546.davem@davemloft.net> <20090413040413.GQ6822@linux.vnet.ibm.com> <20090413095309.631cf395@nehalam> <49E48136.5060700@trash.net> <49E49C65.8060808@cosmosbay.com> <20090414074554.7fa73e2f@nehalam> <49E4B0A5.70404@cosmosbay.com> <20090414111716.28585806@nehalam> <49E4E3E8.5090201@cosmosbay.com> <20090414141351.0f63ac98@nehalam> <49E502B5.7070700@cosmosbay.com> In-Reply-To: <49E502B5.7070700@cosmosbay.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 36 Eric Dumazet wrote: > Stephen Hemminger a ?crit : >> This is an alternative version of ip/ip6/arp tables locking using >> per-cpu locks. This avoids the overhead of synchronize_net() during >> update but still removes the expensive rwlock in earlier versions. >> >> The idea for this came from an earlier version done by Eric Dumazet. >> Locking is done per-cpu, the fast path locks on the current cpu >> and updates counters. The slow case involves acquiring the locks on >> all cpu's. >> >> The mutex that was added for 2.6.30 in xt_table is unnecessary since >> there already is a mutex for xt[af].mutex that is held. >> >> Signed-off-by: Stephen Hemminger >> >> --- >> include/linux/netfilter/x_tables.h | 5 - >> net/ipv4/netfilter/arp_tables.c | 112 +++++++++------------------------ >> net/ipv4/netfilter/ip_tables.c | 123 +++++++++++-------------------------- >> net/ipv6/netfilter/ip6_tables.c | 119 +++++++++++------------------------ >> net/netfilter/x_tables.c | 28 -------- >> 5 files changed, 110 insertions(+), 277 deletions(-) >> > > Tested successfuly on my dev machine, thanks Stephen. > > Signed-off-by: Eric Dumazet Applied, thanks everyone. I'll give it some testing myself and will send it upstream tonight. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/