Subject: Re: [PATCH] Btrfs: setting variable out of order
From: Chris Mason <chris.mason@oracle.com>
To: Eugene Teo <eugeneteo@kernel.sg>
Cc: Yan Zheng <zheng.yan@oracle.com>, linux-kernel@vger.kernel.org
In-Reply-To: <20090415091126.GA13323@kernel.sg>
References: <20090415091126.GA13323@kernel.sg>
Content-Type: text/plain
Date: Wed, 15 Apr 2009 08:59:05 -0400
Message-Id: <1239800345.31633.1.camel@think.oraclecorp.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1047
Lines: 34

On Wed, 2009-04-15 at 17:11 +0800, Eugene Teo wrote:
> This doesn't look intentional.
>
> Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
> ---
>  fs/btrfs/ctree.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index e5b2533..6aa2468 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
> btrfs_trans_handle *trans,
>         for (i = 0; i < nr; i++) {
>                 if (total_size + data_size[i] + sizeof(struct btrfs_item) >
>                     BTRFS_LEAF_DATA_SIZE(root)) {
> -                       break;
>                         nr = i;
> +                       break;
>                	}

Thanks,

This function isn't used anymore, I'll drop it.

-chris


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/