Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756201AbZDOTsK (ORCPT ); Wed, 15 Apr 2009 15:48:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755761AbZDOTrt (ORCPT ); Wed, 15 Apr 2009 15:47:49 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52071 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756308AbZDOTrs (ORCPT ); Wed, 15 Apr 2009 15:47:48 -0400 Date: Wed, 15 Apr 2009 12:43:02 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: "H. Peter Anvin" cc: Ingo Molnar , Thomas Gleixner , Rusty Russell , Linux Kernel Mailing List , Andrew Morton , Dave Jones Subject: Re: Fix quilt merge error in acpi-cpufreq.c In-Reply-To: <49E62BD5.6090508@zytor.com> Message-ID: References: <200904140159.n3E1x1K1014705@hera.kernel.org> <20090414020544.GA3738@elte.hu> <20090415054417.GA5272@elte.hu> <200904152014.11717.rusty@rustcorp.com.au> <20090415162627.GA32254@elte.hu> <49E62BD5.6090508@zytor.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 26 On Wed, 15 Apr 2009, H. Peter Anvin wrote: > > "cleanup" is indeed the most common, as it is intended to signify a > trivial but nonzero code change. Whether or not it's *correct* is > another matter. "build fix" is valid and proper use: it tells that it > fixes a compilation error, which succinctly communicates both the > priority of the fix and how it needs to be validated. Why would that be "proper use"? Dammit, if the "build fix" is not obvious from the rest of the commit message, there's something wrong. And if it _is_ obvious, then the mechanical "Impact:" thing is pointless. In other words - in neither case does it actually help anything at all. It's only distracting noise. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/