Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755495AbZDOVXo (ORCPT ); Wed, 15 Apr 2009 17:23:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752366AbZDOVXf (ORCPT ); Wed, 15 Apr 2009 17:23:35 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57975 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752315AbZDOVXf (ORCPT ); Wed, 15 Apr 2009 17:23:35 -0400 Date: Wed, 15 Apr 2009 14:23:26 -0700 (PDT) Message-Id: <20090415.142326.97287514.davem@davemloft.net> To: torvalds@linux-foundation.org Cc: hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de, rusty@rustcorp.com.au, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, davej@redhat.com Subject: Re: Fix quilt merge error in acpi-cpufreq.c From: David Miller In-Reply-To: References: <49E62BD5.6090508@zytor.com> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 798 Lines: 19 From: Linus Torvalds Date: Wed, 15 Apr 2009 12:43:02 -0700 (PDT) > And if it _is_ obvious, then the mechanical "Impact:" thing is pointless. > > In other words - in neither case does it actually help anything at all. > It's only distracting noise. FWIW I find the Impact: blurbs highly annoying too. Just freakin' say what the damn patch does in the commit message. If a person can't be bothered to skim the commit message text, this Impact: tag only gives them a false sense of understanding what the change does. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/