Message-ID: <49E681B5.8070505@cn.fujitsu.com>
Date: Thu, 16 Apr 2009 08:54:13 +0800
From: Li Zefan <lizf@cn.fujitsu.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Frederic Weisbecker <fweisbec@gmail.com>
CC: Tom Zanussi <tzanussi@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
       Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
       paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH] tracing/filters: allow on-the-fly filter switching
References: <1239610670.6660.49.camel@tropicana> <20090414205635.GA5968@nowhere> <1239769945.7852.21.camel@tropicana> <20090415162151.GH5989@nowhere>
In-Reply-To: <20090415162151.GH5989@nowhere>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1020
Lines: 29

Frederic Weisbecker wrote:
>>> Also, is filter_add_pred() supposed to be available for in-kernel
>>> uses by other tracers or something?
>> No, the current callers were the only ones I'd planned on (it's not
>> static because code in trace_events.c needs to call it).  But, do you
>> see a use for it by other tracers?
> 
> 
> 
> May be in the future, it's possible that a tracer might want to
> set filters by itself.
> But I don't think it has to be fixed now because there are nothing
> like that for now.
> 
> So, no problem :-)
> 

If we restricted the mutex in trace_events_filters.c only, all the
extern functions can be called without lock, and this is what I did
in my previous patch.

>  
>>> If this is planned, the locking could be even deeper than my comments.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/