Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756238AbZDPCBQ (ORCPT ); Wed, 15 Apr 2009 22:01:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753102AbZDPCA6 (ORCPT ); Wed, 15 Apr 2009 22:00:58 -0400 Received: from ozlabs.org ([203.10.76.45]:35831 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753072AbZDPCA6 (ORCPT ); Wed, 15 Apr 2009 22:00:58 -0400 From: Rusty Russell To: "H. Peter Anvin" Subject: Re: Fix quilt merge error in acpi-cpufreq.c Date: Thu, 16 Apr 2009 11:30:26 +0930 User-Agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; i686; ; ) Cc: Linus Torvalds , Ingo Molnar , Thomas Gleixner , Linux Kernel Mailing List , Andrew Morton , Dave Jones References: <200904140159.n3E1x1K1014705@hera.kernel.org> <49E62BD5.6090508@zytor.com> In-Reply-To: <49E62BD5.6090508@zytor.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904161130.28129.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 46 On Thu, 16 Apr 2009 04:17:49 am H. Peter Anvin wrote: > Linus Torvalds wrote: > "build fix" is valid and proper use: it tells that it > fixes a compilation error, which succinctly communicates both the > priority of the fix and how it needs to be validated. Side note: I really prefer to see the compile error output in this case: great for googling. It annoys me when people skip this. Anyway, Impact: had lead me to think harder about my messages than the free-form commit style did. Perhaps it's too rigid, but it helped. Let's get concrete. Here's the top 3 non-merge commits in gitk: ALSA: hda - Fix the cmd cache keys for amp verbs Fix the key value generation for get/set amp verbs. The upper bits of the parameter have to be combined with the verb value to be unique for each direction/index of amp access. This fixes the resume problem on some hardwares like Macbook after the channel mode is changed. I have no idea what this patch does. It seems to be a fix; what are the symptoms of the problem, and how long has it been there? ALSA: add missing definitions(letters) to HD-Audio.txt impact: Add missing definitions(letters). This is actually a pure documentation patch. "Fix typos" or "Documentation fixes" would seem sufficient for subject, and no body needed. ALSA: sound/pci: use memdup_user() Remove open-coded memdup_user(). Again, the body seems gratuitous. Anyone want to try to write a guide on writing good commit messages? Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/