Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752856AbZDPEf0 (ORCPT ); Thu, 16 Apr 2009 00:35:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750914AbZDPEfN (ORCPT ); Thu, 16 Apr 2009 00:35:13 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:51446 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbZDPEfL (ORCPT ); Thu, 16 Apr 2009 00:35:11 -0400 Date: Thu, 16 Apr 2009 10:04:26 +0530 From: Balbir Singh To: Bharata B Rao Cc: KAMEZAWA Hiroyuki , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Subject: Re: [PATCH] Add file based RSS accounting for memory resource controller (v2) Message-ID: <20090416043426.GF7082@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090415120510.GX7082@balbir.in.ibm.com> <20090416095303.b4106e9f.kamezawa.hiroyu@jp.fujitsu.com> <20090416015955.GB7082@balbir.in.ibm.com> <344eb09a0904152059w1a0ecfa4l6ff8c5f2130680ba@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <344eb09a0904152059w1a0ecfa4l6ff8c5f2130680ba@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1746 Lines: 46 * Bharata B Rao [2009-04-16 09:29:53]: > On Thu, Apr 16, 2009 at 7:29 AM, Balbir Singh wrote: > > > > Feature: Add file RSS tracking per memory cgroup > > > > From: Balbir Singh > > > > Changelog v3 -> v2 > > 1. Add corresponding put_cpu() for every get_cpu() > > > > Changelog v2 -> v1 > > > > 1. Rename file_rss to mapped_file > > 2. Add hooks into mem_cgroup_move_account for updating MAPPED_FILE statistics > > 3. Use a better name for the statistics routine. > > > > > > We currently don't track file RSS, the RSS we report is actually anon RSS. > > All the file mapped pages, come in through the page cache and get accounted > > there. This patch adds support for accounting file RSS pages. It should > > > > 1. Help improve the metrics reported by the memory resource controller > > 2. Will form the basis for a future shared memory accounting heuristic > > ? that has been proposed by Kamezawa. > > > > Unfortunately, we cannot rename the existing "rss" keyword used in memory.stat > > to "anon_rss". We however, add "mapped_file" data and hope to educate the end > > user through documentation. > > > > Signed-off-by: Balbir Singh > > Balbir, could you please also update the documentation with the > description about this new metric ? > Yes, I am going to in a follow up patch. I'll send that out after I do some experimentation with shared memory size heuristics. -- Balbir -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/