Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbZDPIoo (ORCPT ); Thu, 16 Apr 2009 04:44:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752598AbZDPIoe (ORCPT ); Thu, 16 Apr 2009 04:44:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34985 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbZDPIoc (ORCPT ); Thu, 16 Apr 2009 04:44:32 -0400 Date: Thu, 16 Apr 2009 10:44:30 +0200 From: Jan Kara To: Linus Torvalds Cc: Chris Mason , "Theodore Ts'o" , Linux Kernel Developers List , Ext4 Developers List Subject: Re: [PATCH RFC] ext3 data=guarded v3 Message-ID: <20090416084430.GA14150@duck.suse.cz> References: <1239816159-6868-1-git-send-email-chris.mason@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 30 On Wed 15-04-09 13:35:23, Linus Torvalds wrote: > > > On Wed, 15 Apr 2009, Chris Mason wrote: > > > > Here is another version of the data=guarded work for ext3. The main > > difference between this code and yesterday's is the guarded writepage > > function now sends any newly allocated block through the old data=ordered code. > > I'm inclined to apply the first two patches as infrastructure, since they > seem to make sense regardless of data=ordered. The ability to get a > callback when IO ends sounds like something that a number of cases might > find intriguing, and it's obviously how the actual IO has worked > internally anyway. > > Comments? Yes, the first two patches look fine to me. I tried to review the third patch yesterday but my mind has blown up when trying to track all the possible interactions and I started doing something else to preserve last bits of sanity ;). Will retry later... Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/