Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758378AbZDPQzw (ORCPT ); Thu, 16 Apr 2009 12:55:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753686AbZDPQzj (ORCPT ); Thu, 16 Apr 2009 12:55:39 -0400 Received: from verein.lst.de ([213.95.11.210]:37823 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753537AbZDPQzi (ORCPT ); Thu, 16 Apr 2009 12:55:38 -0400 Date: Thu, 16 Apr 2009 18:53:43 +0200 From: Christoph Hellwig To: "Frank Ch. Eigler" Cc: Theodore Tso , Steven Rostedt , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Frederic Weisbecker , Arjan van de Ven , Christoph Hellwig , Mathieu Desnoyers , Jeremy Fitzhardinge , Lai Jiangshan , Zhaolei , Li Zefan , KOSAKI Motohiro , Masami Hiramatsu , Tom Zanussi , Jiaying Zhang , Michael Rubin , Martin Bligh Subject: Re: [PATCH 0/8] [GIT PULL] TRACE_EVENT for modules Message-ID: <20090416165343.GE5933@lst.de> References: <20090414172337.280621613@goodmis.org> <20090414210445.GM955@mit.edu> <20090414212917.GA19933@elastic.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090414212917.GA19933@elastic.org> User-Agent: Mutt/1.3.28i X-Spam-Score: -0.001 () BAYES_44 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 25 On Tue, Apr 14, 2009 at 05:29:17PM -0400, Frank Ch. Eigler wrote: > Hi - > > On Tue, Apr 14, 2009 at 05:04:45PM -0400, Theodore Tso wrote: > > [...] > > One thing which I would really like is to avoid needing to drop the > > header file in include/trace/. > > > > The problem that I have with this is that for ext4, we need to access > > private data structures which are defined in header files in > > fs/ext4/*.h --- which we moved into fs/ext4 a long time ago [...] > > If the tracepoints/events expand to code that exposes those private > structures, then those structures are perhaps not quite so private any > more. That argues for moving those headers back under include/..., or > at least those type decls made reachable from the tracepoints. They expose them to the TRACE_EVENT output format, which then pretty-prints them. They are still as private to the module as it gets. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/