From: David Woodhouse <dwmw2@infradead.org>
To: torvalds@transmeta.com, davem@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: recalc_sigpending() / recalc_sigpending_tsk() ?
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 28 Feb 2002 16:31:25 +0000
Message-ID: <22659.1014913885@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org

I'm looking at merging the changes made to JFFS2 in 2.5, with the intention 
of again having a single codebase that compiles in both 2.5 and 2.4.

I'm a little confused by the changes to recalc_sigpending().

It seems that the name of the function was changed to recalc_sigpending_tsk()
and a new function called recalc_sigpending() was added.

Was there a reason for doing this, rather than just introducing the new 
function with a different name, such as recalc_sigpending_cur()? It breaks 
2.4 source compatibility in a way that seems entirely gratuitous.

Before I have to go and do something evil in my compatmac.h to work round 
this, is there any chance of putting the original recalc_sigpending() back?

Linus, would you accept such a patch?

--
dwmw2

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,5)
#include <linux/sched.h>
/* Grrr. Gratuitous breakage */
#define recalc_sigpending() recalc_sigpending(current)
/* Unfortunately this one can't work, because of the above
#define recalc_sigpending_tsk(t) recalc_sigpending(t)
 */
#endif


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/