Date: Fri, 17 Apr 2009 09:20:40 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrea Righi <righi.andrea@gmail.com>, menage@google.com,
       balbir@linux.vnet.ibm.com, guijianfeng@cn.fujitsu.com,
       agk@sourceware.org, axboe@kernel.dk, baramsori72@gmail.com,
       chlunde@ping.uio.no, dave@linux.vnet.ibm.com, dpshah@google.com,
       eric.rannaud@gmail.com, fernando@oss.ntt.co.jp, taka@valinux.co.jp,
       lizf@cn.fujitsu.com, matt@bluehost.com, dradford@bluehost.com,
       ngupta@google.com, randy.dunlap@oracle.com, roberto@unbit.it,
       ryov@valinux.co.jp, s-uchida@ap.jp.nec.com, subrata@linux.vnet.ibm.com,
       yoshikawa.takuya@oss.ntt.co.jp, containers@lists.linux-foundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] bio-cgroup controller
Message-Id: <20090417092040.1c832c69.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <20090416152937.b2188370.akpm@linux-foundation.org>
References: <1239740480-28125-1-git-send-email-righi.andrea@gmail.com>
	<1239740480-28125-4-git-send-email-righi.andrea@gmail.com>
	<20090416152937.b2188370.akpm@linux-foundation.org>
Organization: FUJITSU Co. LTD.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1640
Lines: 48

On Thu, 16 Apr 2009 15:29:37 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 14 Apr 2009 22:21:14 +0200
> Andrea Righi <righi.andrea@gmail.com> wrote:
> 
> > Subject: [PATCH 3/9] bio-cgroup controller
> 
> Sorry, but I have to register extreme distress at the name of this. 
> The term "bio" is well-established in the kernel and here we have a new
> definition for the same term: "block I/O".
> 
> "bio" was a fine term for you to have chosen from the user's
> perspective, but from the kernel developer perspective it is quite
> horrid.  The patch adds a vast number of new symbols all into the
> existing "bio_" namespace, many of which aren't related to `struct bio'
> at all.
> 
> At least, I think that's what's happening.  Perhaps the controller
> really _is_ designed to track `struct bio'?  If so, that's an odd thing
> to tell userspace about.
> 
Hmm, how about iotrack-cgroup ?

Thanks,
-Kame


> 
> > The controller bio-cgroup is used by io-throttle to track writeback IO
> > and for properly apply throttling.
> 
> Presumably it tracks all forms of block-based I/O and not just delayed
> writeback.
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/