Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756444AbZDQBXe (ORCPT ); Thu, 16 Apr 2009 21:23:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755039AbZDQBWz (ORCPT ); Thu, 16 Apr 2009 21:22:55 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:56521 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350AbZDQBWy (ORCPT ); Thu, 16 Apr 2009 21:22:54 -0400 Date: Thu, 16 Apr 2009 21:22:53 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Jeremy Fitzhardinge cc: mathieu.desnoyers@polymtl.ca, Ingo Molnar , linux-kernel@vger.kernel.org, "Paul E. McKenney" , Andrew Morton , Christoph Hellwig Subject: Re: [patch 2/3] RCU move trace defines to rcupdate_types.h In-Reply-To: <49E7D701.9090407@goop.org> Message-ID: References: <20090417003755.276959950@polymtl.ca> <20090417003931.846405986@polymtl.ca> <49E7D701.9090407@goop.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 624 Lines: 17 On Thu, 16 Apr 2009, Jeremy Fitzhardinge wrote: > I don't think this helps. rcupdate_types.h uses preempt_disable/enable, but > doesn't include linux/preempt.h for them - but someone's going to have to, so > you've got an implicit dependency on the user to #include the right headers in > advance. Would including linux/preempt.h in rcupdate_types.h be a problem? -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/