Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759893AbZDQG6W (ORCPT ); Fri, 17 Apr 2009 02:58:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752150AbZDQG6J (ORCPT ); Fri, 17 Apr 2009 02:58:09 -0400 Received: from qw-out-2122.google.com ([74.125.92.25]:62440 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754240AbZDQG6G convert rfc822-to-8bit (ORCPT ); Fri, 17 Apr 2009 02:58:06 -0400 MIME-Version: 1.0 In-Reply-To: <1d3f23370904162201s21fc7d90q8bc4aacafa5a7ada@mail.gmail.com> References: <1239875798-10523-1-git-send-email-monstr@monstr.eu> <1f1874e0192d8481356551ffbeeebcecce951afc.1239874968.git.monstr@monstr.eu> <157375351273eacf9b552e677447505542f90521.1239874968.git.monstr@monstr.eu> <74602b0d6e166c6a657f3d9b7f6c3890b0783326.1239874968.git.monstr@monstr.eu> <764365e7af2e476e43cd674738e51f13b306979b.1239874968.git.monstr@monstr.eu> <74c0088dfda1816c21914c0a8da0c42908526c5e.1239874968.git.monstr@monstr.eu> <1d3f23370904162201s21fc7d90q8bc4aacafa5a7ada@mail.gmail.com> From: Grant Likely Date: Fri, 17 Apr 2009 00:52:02 -0600 Message-ID: Subject: Re: [microblaze-uclinux] [PATCH 11/11] microblaze: Kconfig: Enable drivers for Microblaze To: John Williams Cc: microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org, Michal Simek Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1810 Lines: 57 On Thu, Apr 16, 2009 at 11:01 PM, John Williams wrote: > On Thu, Apr 16, 2009 at 7:56 PM, ? wrote: >> From: Michal Simek >> >> Signed-off-by: Michal Simek > > ACK from a MicroBlaze perspective, but some other comments below: Acked-by: Grant Likely But I'm not sure who should pick this up. > > A note more for the Xilinx PPC folks (ie Grant Likely): > > Shouldn't some of these Kconfig depends for PPC be unified? ?We have: > >> ?config XILINX_SYSACE >> ? ? ? ?tristate "Xilinx SystemACE support" >> - ? ? ? depends on 4xx >> + ? ? ? depends on 4xx || MICROBLAZE > >> ?config XILINX_HWICAP >> ? ? ? ?tristate "Xilinx HWICAP Support" >> - ? ? ? depends on XILINX_VIRTEX >> + ? ? ? depends on XILINX_VIRTEX || MICROBLAZE > > >> ?config GPIO_XILINX >> ? ? ? ?bool "Xilinx GPIO support" >> - ? ? ? depends on PPC_OF >> + ? ? ? depends on PPC_OF || MICROBLAZE >> ? ? ? ?help >> ? ? ? ? ?Say yes here to support the Xilinx FPGA GPIO device > > Are these all really different options? ?PPC_OF? ?XILINX_VIRTEX? ?4xx? xsysace should just depend on either PPC or OF. It is applicable to more than just virtex/spartan systems (I know of at least one non-virtex 440 board with a systemace, hence the 4xx usage), and it is conceivable that it would be used on other architectures. XILINX_VIRTEX makes some sense for hwicap PPC_OF doesn't have any real meaning anymore. PPC would be better. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/