Message-ID: <49E866E0.2090007@jp.fujitsu.com>
Date: Fri, 17 Apr 2009 20:24:16 +0900
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
User-Agent: Thunderbird 2.0.0.21 (Windows/20090302)
MIME-Version: 1.0
To: Andi Kleen <andi@firstfloor.org>
CC: hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
       tglx@linutronix.de
Subject: Re: [PATCH] [22/28] x86: MCE: Default to panic timeout for machine
 checks
References: <20090407507.636692542@firstfloor.org> <20090407150805.588AA1D046D@basil.firstfloor.org>
In-Reply-To: <20090407150805.588AA1D046D@basil.firstfloor.org>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1003
Lines: 27

Andi Kleen wrote:
> Fatal machine checks can be logged to disk after boot, but only if
> the system did a warm reboot. That's unfortunately difficult with the
> default panic behaviour, which waits forever and the admin has to
> press the power button because modern systems usually miss a reset button.
> This clears the machine checks in the registers and make
> it impossible to log them.
> 
> This patch changes the default for machine check panic to always
> reboot after 30s. Then the mce can be successfully logged after
> reboot.

In case if user already set panic_timeout to 5s, the that user need to
wait extra 25s for machine check panic... ?

The idea is good, but I think some switch like "no_reboot_on_mce" would
be required.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/