Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760463AbZDQN6A (ORCPT ); Fri, 17 Apr 2009 09:58:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752618AbZDQN5v (ORCPT ); Fri, 17 Apr 2009 09:57:51 -0400 Received: from mtoichi13.ns.itscom.net ([219.110.2.183]:40073 "EHLO mtoichi13.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755340AbZDQN5v (ORCPT ); Fri, 17 Apr 2009 09:57:51 -0400 From: hooanon05@yahoo.co.jp Subject: Re: IMA and fs To: Mimi Zohar Cc: linux-kernel@vger.kernel.org, david safford In-Reply-To: References: <15909.1239887985@jrobl> Date: Fri, 17 Apr 2009 22:57:46 +0900 Message-ID: <11555.1239976666@jrobl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 28 Mimi Zohar: > > xfs_iget() holds spinlock before xfs_iget_cache_hit(), and > > ima_inode_alloc() cannot use GFP_KERNEL. > > This looks similar to the xfs - IMA problem discussed > http://lkml.org/lkml/2009/2/20/327. Yes, the same issue. I didn't know it was discussed before. So what is the conclusion? Are you waiting for fixing the spinlock in xfs? > > Does nfsd_open() need to to call ima_path_check()? ::: > Yes, in order for the open/free to be balanced in ima_file_free(). Then how about putting ima_path_check() into __dentry_open() instead of may_open()? J. R. Okajima -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/