Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758663AbZDQPRE (ORCPT ); Fri, 17 Apr 2009 11:17:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761030AbZDQPQx (ORCPT ); Fri, 17 Apr 2009 11:16:53 -0400 Received: from tomts5-srv.bellnexxia.net ([209.226.175.25]:40909 "EHLO tomts5-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759800AbZDQPQw (ORCPT ); Fri, 17 Apr 2009 11:16:52 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlAFAE826ElMQW1W/2dsb2JhbACBTs8Bg30G Date: Fri, 17 Apr 2009 11:16:46 -0400 From: Mathieu Desnoyers To: Jeremy Fitzhardinge Cc: Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org, "Paul E. McKenney" , Andrew Morton , Christoph Hellwig Subject: Re: [patch 2/3] RCU move trace defines to rcupdate_types.h Message-ID: <20090417151646.GB13842@Krystal> References: <20090417003755.276959950@polymtl.ca> <20090417003931.846405986@polymtl.ca> <49E7D701.9090407@goop.org> <20090417014209.GA24956@Krystal> <49E81A63.7010700@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <49E81A63.7010700@goop.org> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 11:15:42 up 48 days, 11:41, 3 users, load average: 0.69, 0.58, 0.51 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2405 Lines: 81 * Jeremy Fitzhardinge (jeremy@goop.org) wrote: > Mathieu Desnoyers wrote: >> * Steven Rostedt (rostedt@goodmis.org) wrote: >> >>> On Thu, 16 Apr 2009, Jeremy Fitzhardinge wrote: >>> >>> >>>> I don't think this helps. rcupdate_types.h uses preempt_disable/enable, but >>>> doesn't include linux/preempt.h for them - but someone's going to have to, so >>>> you've got an implicit dependency on the user to #include the right headers in >>>> advance. >>>> >>> Would including linux/preempt.h in rcupdate_types.h be a problem? >>> >>> -- Steve >>> >>> >> >> I did not include preempt.h in rcupdate_types.h because rcupdate.h did >> not include it, so I thought it had a special status such a kernel.h. >> However, I notice the rcupdate.h includes spinlock.h, which in turn >> includes preempt.h, so we would need to include preempt.h in >> rcupdate_types.h. >> >> But I think preempt.h is pretty much only type definitions. I don't >> think that would be a problem, but maybe Jeremy knows better. > > No, preempt.h has fairly complex #include requirements: > #include > #include > #include > > which in turn include: > /* linux/thread_info */ > #include > #include > > /* list.h */ > #include > #include > #include > #include > > And from there more complex still: > #include > #include > #include > #include > #include > #include > #include > #include > #include > #include > #include > [...and much more...] > > Given that paravirt.h is included in some of those headers, it > eventually gets cyclic. > OK. Given the simplicity of the preempt_disable/enable_notrace found in preempt.h, we could move them to include/preempt_types.h too, and that would solve all problems, wouldn't it ? Mathieu > J -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/