Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759713AbZDQPxS (ORCPT ); Fri, 17 Apr 2009 11:53:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753697AbZDQPxI (ORCPT ); Fri, 17 Apr 2009 11:53:08 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:53923 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751110AbZDQPxH (ORCPT ); Fri, 17 Apr 2009 11:53:07 -0400 Date: Fri, 17 Apr 2009 11:53:05 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Jeremy Fitzhardinge cc: mathieu.desnoyers@polymtl.ca, Ingo Molnar , Linux Kernel Mailing List , Jeremy Fitzhardinge Subject: Re: [PATCH 4/4] tracing: avoid warnings from zero-arg tracepoints In-Reply-To: <1239950139-1119-5-git-send-email-jeremy@goop.org> Message-ID: References: <1239950139-1119-1-git-send-email-jeremy@goop.org> <1239950139-1119-5-git-send-email-jeremy@goop.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 42 On Thu, 16 Apr 2009, Jeremy Fitzhardinge wrote: > From: Jeremy Fitzhardinge > > Tracepoints with no arguments can issue two warnings: > "field" defined by not used > "ret" is uninitialized in this function > > Mark field as being OK to leave unused, and initialize ret. > > Signed-off-by: Jeremy Fitzhardinge > --- > include/trace/ftrace.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > index 60c5323..39a3351 100644 > --- a/include/trace/ftrace.h > +++ b/include/trace/ftrace.h > @@ -160,8 +160,8 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \ > static int \ > ftrace_format_##call(struct trace_seq *s) \ > { \ > - struct ftrace_raw_##call field; \ > - int ret; \ > + struct ftrace_raw_##call field __attribute__((unused)); \ > + int ret = 0; \ > \ > tstruct; \ > \ Acked-by: Steven Rostedt -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/