Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762107AbZDQQch (ORCPT ); Fri, 17 Apr 2009 12:32:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761874AbZDQQc1 (ORCPT ); Fri, 17 Apr 2009 12:32:27 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:51821 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761771AbZDQQc0 (ORCPT ); Fri, 17 Apr 2009 12:32:26 -0400 Date: Fri, 17 Apr 2009 12:32:24 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Jeremy Fitzhardinge cc: mathieu.desnoyers@polymtl.ca, Ingo Molnar , Linux Kernel Mailing List , Jeremy Fitzhardinge Subject: Re: [PATCH 2/4] x86/pvops: target CREATE_TRACE_POINTS to particular subsystems In-Reply-To: <49E8AAC8.5080004@goop.org> Message-ID: References: <1239950139-1119-1-git-send-email-jeremy@goop.org> <1239950139-1119-3-git-send-email-jeremy@goop.org> <49E8AAC8.5080004@goop.org> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 45 On Fri, 17 Apr 2009, Jeremy Fitzhardinge wrote: > Steven Rostedt wrote: > > Instead of doing it this way, what about not having this new header, and > > just do: > > > > > > #ifdef CREATE_IRQ_TRACE_POINTS > > #define CREATE_TRACE_POINTS > > #endif > > #include > > > > Heck, define_trace.h is only defined when CREATE_TRACE_POINTS is defined, > > why not just remove that and have: > > > > #ifdef CREATE_IRQ_TRACE_POINTS > > #define > > #endif > > > > The whole trickery with the CREATE_TRACE_POINTS was to avoid the #if in the > > trace headers anyway. If we can't avoid it. We don't need to add more > > confusion to the mix. > > > > OK, and remove the test for CREATE_TRACE_POINTS in define_trace.h altogether? > Works for me. > Uh, still needs the #undef CREATE_IRQ_TRACE_POINTS. Ah yes! It needs to be: #ifdef CONFIG_IRQ_TRACE_POINTS #undef CONFIG_IRQ_TRACE_POINTS #include #endif Otherwise we get into the recursion again. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/