Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762594AbZDQSPl (ORCPT ); Fri, 17 Apr 2009 14:15:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761782AbZDQSPc (ORCPT ); Fri, 17 Apr 2009 14:15:32 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:39973 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756389AbZDQSPb (ORCPT ); Fri, 17 Apr 2009 14:15:31 -0400 Date: Fri, 17 Apr 2009 11:03:31 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Jonathan Corbet cc: Peter Zijlstra , Ingo Molnar , Al Viro , Alessio Igor Bogani , Alexander Viro , Frederic Weisbecker , LKML , Matthew Wilcox Subject: Re: [PATCH -tip] remove the BKL: Replace BKL in mount/umount syscalls with a mutex In-Reply-To: <20090417113142.3151579b@bike.lwn.net> Message-ID: References: <1239892078-6039-1-git-send-email-abogani@texware.it> <20090416160645.GB17804@elte.hu> <20090416235649.GF26366@ZenIV.linux.org.uk> <20090417000142.GF21405@elte.hu> <20090417001345.GH26366@ZenIV.linux.org.uk> <20090417002744.GB29630@elte.hu> <20090417003805.GI26366@ZenIV.linux.org.uk> <20090417165643.GL8253@elte.hu> <1239987885.23397.4817.camel@laptop> <20090417113142.3151579b@bike.lwn.net> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 37 On Fri, 17 Apr 2009, Jonathan Corbet wrote: > On Fri, 17 Apr 2009 10:21:06 -0700 (PDT) > Linus Torvalds wrote: > > > And I know we had patches for file locking BKL-removal at some point. What > > happened to them? Were they just broken, or forgotten, or waiting in Jon's > > tree, or what? > > Not in my tree, I've not seen them. I could maybe take a look at that, > I've just about recovered from my fasync experience...:) Hmm. It might also just be my fevered imagination. I'd like to say it was Matthew Wilcox, but really, my mind is going. Ahh. Bug google backs me up. As long as I have google, I can keep Alzheimer's at bay: "Negative scalability by removal of lock_kernel()" thread on lkml back in October 2000. After we had actually done the BKL removal. So we actually did apply it (in 2.4.0-test9, and then reverted it again (in -test11, I think). Google for "file_lock_sem fs/locks.c" and see some of the discussion. The end result was to go back to the BKL due to Apache slowdowns. But I seem to remember a later patch (in the last year or two) from Willy too. Google doesn't help me, so that's probably just my fevered mind. But I'm cc'ing Willy anyway. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/