Date: Fri, 17 Apr 2009 15:18:53 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: randy.dunlap@oracle.com, torvalds@linux-foundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/10] MAINTAINERS - add script, patterns and misc
 updates
Message-Id: <20090417151853.6f02d8d3.akpm@linux-foundation.org>
In-Reply-To: <1240006168.31116.62.camel@localhost>
References: <1239167872-8179-1-git-send-email-joe@perches.com>
	<20090417134711.ba0f03e7.randy.dunlap@oracle.com>
	<1240003652.31116.44.camel@localhost>
	<20090417144117.4ac8828f.akpm@linux-foundation.org>
	<1240006168.31116.62.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1603
Lines: 49

On Fri, 17 Apr 2009 15:09:28 -0700
Joe Perches <joe@perches.com> wrote:

> On Fri, 2009-04-17 at 14:41 -0700, Andrew Morton wrote:
> > Lots of people's scripts/get_maintainer.pl files won't have the `x' bit
> > set because patch(1) is dumb.  So for reliability it's best to always do
> 
> git at least persisted the "x" bit.
> checkpatch doesn't say to use perl.
> 
> > 	perl ./scripts/get_maintainer.pl
> 
> OK by me.
> 
> > : akpm:/usr/src/25> perl scripts/get_maintainer.pl -f fs/ext3/inode.c 
> > : grep: The -P option is not supported
> >     that's odd.  `man grep' on this machine says
> 
> I changed the script grep to use "-E", which is older.
> 
> > : fatal: Not a git repository
> > 
> >     it whines about not being run in a git directory, but does a decent
> >     job anyway.  
> 
> Oh, I see, you've git installed, but not in your
> /usr/src/25 directory.
> 
> I changed the script to verify that a .git directory
> exists before running git.

hm, well, there's benefit in telling the user "hey, you'll get better
results if you run this in your git directory".

> How about with these 2 patches applied?
> 

akpm:/usr/src/25> perl scripts/get_maintainer.pl -f fs/ext3/inode.c
Andreas Dilger <adilger@sun.com>
Andrew Morton <akpm@linux-foundation.org>
Stephen Tweedie <sct@redhat.com>
linux-ext4@vger.kernel.org
linux-kernel@vger.kernel.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/