Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756778AbZDQWoP (ORCPT ); Fri, 17 Apr 2009 18:44:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753279AbZDQWn5 (ORCPT ); Fri, 17 Apr 2009 18:43:57 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:36020 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbZDQWn5 (ORCPT ); Fri, 17 Apr 2009 18:43:57 -0400 Date: Fri, 17 Apr 2009 23:43:50 +0100 From: Al Viro To: David Woodhouse Cc: hooanon05@yahoo.co.jp, hch@infradead.org, "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: Q: NFSD readdir in linux-2.6.28 Message-ID: <20090417224350.GN26366@ZenIV.linux.org.uk> References: <8036.1237474444@jrobl> <1237475837.16359.106.camel@macbook.infradead.org> <8913.1237476890@jrobl> <1239960739.3428.33.camel@macbook.infradead.org> <20090417193233.GM26366@ZenIV.linux.org.uk> <1240006620.19059.41.camel@macbook.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240006620.19059.41.camel@macbook.infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1324 Lines: 25 On Fri, Apr 17, 2009 at 11:17:00PM +0100, David Woodhouse wrote: > It sounds like the better answer is to just make sure i_mutex is held > when nfsd_buffered_readdir() calls back into the provided filldir > function (we could do it in the various filldir functions themselves, > _if_ they call lookup_one_len(), but I think I prefer it this way -- > it's simpler). Patch below for comment. Umm... I can live with that, assuming that we don't have callbacks that take i_mutex themselves. AFAICS, everything we call there is either obviously not touching i_mutex or is already called while we hold i_mutex elsewhere, but I'd appreciate if somebody actually tested that sucker for different versions of protocol... > (While I'm staring at it, it looks like nfsd_buffered_readdir() should > be returning a __be32 not an int, and its 'return -ENOMEM' should be > 'return nfserrno(-ENOMEM)'. The first bug I inherited from the existing > nfsd_do_readdir() when I replaced it, but the second is all my own. I'll > send a patch to fix those shortly.) Fold it into this one, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/