Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760053AbZDQXiT (ORCPT ); Fri, 17 Apr 2009 19:38:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752975AbZDQXiD (ORCPT ); Fri, 17 Apr 2009 19:38:03 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:43393 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbZDQXiB (ORCPT ); Fri, 17 Apr 2009 19:38:01 -0400 Date: Sat, 18 Apr 2009 00:37:55 +0100 From: Al Viro To: David Woodhouse Cc: hooanon05@yahoo.co.jp, hch@infradead.org, "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: Q: NFSD readdir in linux-2.6.28 Message-ID: <20090417233755.GP26366@ZenIV.linux.org.uk> References: <8036.1237474444@jrobl> <1237475837.16359.106.camel@macbook.infradead.org> <8913.1237476890@jrobl> <1239960739.3428.33.camel@macbook.infradead.org> <20090417193233.GM26366@ZenIV.linux.org.uk> <1240006620.19059.41.camel@macbook.infradead.org> <20090417224350.GN26366@ZenIV.linux.org.uk> <20090417225306.GO26366@ZenIV.linux.org.uk> <1240010612.21423.34.camel@macbook.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240010612.21423.34.camel@macbook.infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 910 Lines: 33 On Sat, Apr 18, 2009 at 12:23:32AM +0100, David Woodhouse wrote: > Or, to phrase my last response slightly differently... because I don't > like either of these two versions very much... Eh? Just have host_err = mutex_lock_killable(....); if (host_err) break; de = ... while (size > 0) { offset = de->offset; if (func(cdp, de->name, de->namlen, de->offset, de->ino, de->d_type)) break; if (cdp->err != nfs_ok) break; ... size -= reclen; de = ... } mutex_unlock(....); if (size > 0) /* we'd an error */ break; offset = vfs_llseek(....); } free_page(....); and to hell with all goto in there... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/