Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759387AbZDRA6s (ORCPT ); Fri, 17 Apr 2009 20:58:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752964AbZDRA6k (ORCPT ); Fri, 17 Apr 2009 20:58:40 -0400 Received: from norsk5.dsl.xmission.com ([166.70.24.44]:11261 "EHLO master.douglaskthompson.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752777AbZDRA6j (ORCPT ); Fri, 17 Apr 2009 20:58:39 -0400 Date: Fri, 17 Apr 2009 18:58:38 -0600 From: dougthompson@xmission.com To: djiang@mvista.com, jharan@Brocade.COM, dougthompson@xmission.com, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH 1/1] edac: ppc mpc85xx fix mc err detect Message-ID: <49e925be.mjq9Fl6et5TONkn5%dougthompson@xmission.com> User-Agent: Heirloom mailx 12.2 01/07/07 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1412 Lines: 39 From: Dave Jiang Error found by Jeff Haran The error detect register is 0s when no errors are detected. The check code is incorrect, so reverse check sense. Cc: Jeff Haran Signed-off-by: Dave Jiang Signed-off-by: Doug Thompson --- commit 1d8cad7d0ecbe9fad3c70b959804e6c6632e236c tree ed8e099c0c0b775b1c11b94dfc794491a915e144 parent b0cbc861a3c05e634520b049b5cc27ad6febb51f author Dave Jiang Mon, 13 Apr 2009 10:16:53 -0700 committer Dave Jiang Mon, 13 Apr 2009 10:16:53 -0700 drivers/edac/mpc85xx_edac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index 4637a4a..7c8c2d7 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci) int row_index; err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT); - if (err_detect) + if (!err_detect) return; mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n", -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/