Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756128AbZDRNEb (ORCPT ); Sat, 18 Apr 2009 09:04:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755157AbZDRNEV (ORCPT ); Sat, 18 Apr 2009 09:04:21 -0400 Received: from rv-out-0506.google.com ([209.85.198.228]:39649 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbZDRNET convert rfc822-to-8bit (ORCPT ); Sat, 18 Apr 2009 09:04:19 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=elH4D/QvvFvvMLEQOqLuGqDS3i0pV6QPhWKUXXzZqJDQVYCz/9Fk9CN0Z4NWJ7KU2y US3v/W/rjUehsVcRr5Pok0c7RJwU8pc60h7ODIeWLI/u4kW9gMH54JcCBwVQubTwFsdA /LZeVX9VSvcu7/pDRSS9qGEngD4Z+DtcQ4q6A= MIME-Version: 1.0 In-Reply-To: References: <8db1092f0904070037q426fd8dcx4aa48c70e40b5d6c@mail.gmail.com> <20090409212028.7b2aa88c.akpm@linux-foundation.org> <8db1092f0904100340g7b7eb310y805e8680a32e3ac8@mail.gmail.com> <8db1092f0904100747w297a0daas9ebd05486d06e706@mail.gmail.com> <8db1092f0904100952x64048907gea6bbaf25488de26@mail.gmail.com> <8db1092f0904101057x56000b73w9de3227b2a3a9abb@mail.gmail.com> Date: Sat, 18 Apr 2009 21:04:18 +0800 Message-ID: Subject: Re: [2.6.29-git12] BUG: scheduling while atomic: swapper/0/0x10000100 From: Dave Young To: Thomas Gleixner Cc: Maciej Rutecki , Andrew Morton , Linux Kernel Mailing List , linux-bluetooth@vger.kernel.org, marcel@holtmann.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7678 Lines: 151 On Sat, Apr 11, 2009 at 2:25 AM, Thomas Gleixner wrote: > Maciej, > > On Fri, 10 Apr 2009, Maciej Rutecki wrote: >> 2009/4/10 Thomas Gleixner : >> >> [...] >> > Please upload trace.bz2 file to some place. >> >> http://unixy.pl/maciek/download/kernel/2.6.30-rc1-git3/laptop/trace-2.6.30-rc1-git3.bz2 > > Ok. That gives us the necessary information: > > -0 1d... 76597263us : do_softirq <-irq_exit > -0 1d... 76597263us : __do_softirq <-do_softirq > -0 1..s. 76597264us : tasklet_action <-__do_softirq > -0 1..s. 76597265us : hci_rx_task <-tasklet_action > -0 1..s. 76597266us : _read_lock <-hci_rx_task > -0 1..s. 76597267us : skb_dequeue <-hci_rx_task > -0 1..s. 76597268us : _spin_lock_irqsave <-skb_dequeue > -0 1d.s. 76597269us : _spin_unlock_irqrestore <-skb_dequeue > -0 1..s. 76597270us : hci_send_to_sock <-hci_rx_task > -0 1..s. 76597270us+: _read_lock <-hci_send_to_sock > -0 1..s. 76597272us : skb_clone <-hci_send_to_sock > -0 1..s. 76597273us : kmem_cache_alloc <-skb_clone > -0 1..s. 76597274us : __skb_clone <-skb_clone > -0 1..s. 76597275us : __copy_skb_header <-__skb_clone > -0 1..s. 76597276us : skb_push <-hci_send_to_sock > -0 1..s. 76597277us : sock_queue_rcv_skb <-hci_send_to_sock > -0 1..s. 76597278us : sk_filter <-sock_queue_rcv_skb > -0 1..s. 76597279us : security_sock_rcv_skb <-sk_filter > -0 1..s. 76597280us : cap_socket_sock_rcv_skb <-security_sock_rcv_skb > -0 1..s. 76597280us : local_bh_disable <-sk_filter > -0 1..s. 76597281us : local_bh_enable <-sk_filter > -0 1..s. 76597282us : skb_queue_tail <-sock_queue_rcv_skb > -0 1..s. 76597283us : _spin_lock_irqsave <-skb_queue_tail > -0 1d.s. 76597284us : _spin_unlock_irqrestore <-skb_queue_tail > -0 1..s. 76597285us : sock_def_readable <-sock_queue_rcv_skb > -0 1..s. 76597286us : _read_lock <-sock_def_readable > -0 1..s. 76597286us : __wake_up_sync_key <-sock_def_readable > -0 1..s. 76597287us : _spin_lock_irqsave <-__wake_up_sync_key > -0 1d.s. 76597288us : __wake_up_common <-__wake_up_sync_key > -0 1d.s. 76597289us : pollwake <-__wake_up_common > -0 1d.s. 76597290us : default_wake_function <-pollwake > -0 1d.s. 76597290us : try_to_wake_up <-default_wake_function > -0 1d.s. 76597292us : update_shares <-try_to_wake_up > -0 1d.s. 76597293us : walk_tg_tree <-update_shares > -0 1d.s. 76597294us : tg_nop <-walk_tg_tree > -0 1d.s. 76597294us : tg_nop <-walk_tg_tree > -0 1d.s. 76597295us : tg_shares_up <-walk_tg_tree > -0 1d.s. 76597297us : tg_nop <-walk_tg_tree > -0 1d.s. 76597297us : tg_shares_up <-walk_tg_tree > -0 1d.s. 76597298us : tg_nop <-walk_tg_tree > -0 1d.s. 76597299us : tg_shares_up <-walk_tg_tree > -0 1d.s. 76597300us : tg_nop <-walk_tg_tree > -0 1d.s. 76597301us : tg_shares_up <-walk_tg_tree > -0 1d.s. 76597302us : tg_nop <-walk_tg_tree > -0 1d.s. 76597303us : tg_shares_up <-walk_tg_tree > -0 1d.s. 76597304us : tg_shares_up <-walk_tg_tree > -0 1d.s. 76597305us+: task_rq_lock <-try_to_wake_up > -0 1d.s. 76597314us : _spin_lock <-task_rq_lock > -0 1d.s. 76597315us : select_task_rq_fair <-try_to_wake_up > -0 1d.s. 76597316us : activate_task <-try_to_wake_up > -0 1d.s. 76597317us : enqueue_task_fair <-activate_task > -0 1d.s. 76597317us : enqueue_entity <-enqueue_task_fair > -0 1d.s. 76597318us : update_curr <-enqueue_entity > -0 1d.s. 76597319us : place_entity <-enqueue_entity > -0 1d.s. 76597320us : enqueue_entity <-enqueue_task_fair > -0 1d.s. 76597321us : update_curr <-enqueue_entity > -0 1d.s. 76597321us : place_entity <-enqueue_entity > -0 1d.s. 76597322us : check_preempt_curr_idle <-try_to_wake_up > -0 1d.s. 76597323us : resched_task <-check_preempt_curr_idle > -0 1dNs. 76597324us : _spin_unlock_irqrestore <-try_to_wake_up > -0 1dNs. 76597325us+: _spin_unlock_irqrestore <-__wake_up_sync_key > -0 1.Ns. 76597326us : hci_event_packet <-hci_rx_task > -0 1.Ns. 76597327us : skb_pull <-hci_event_packet > -0 1.Ns. 76597328us : _spin_lock <-hci_event_packet > -0 1.Ns. 76597330us : del_timer <-hci_event_packet > -0 1.Ns. 76597331us : hci_conn_add_sysfs <-hci_event_packet > -0 1.Ns. 76597332us+: dev_set_name <-hci_conn_add_sysfs Marcel, this is caused by hci conn id changes, originally the conn id is like "acl:xx:xx:xx:xx:xx:xx", then it was changed to "hdev_name:connection_handle", yes use the handle looks better, but it need to be done in the event handling function. What do you think about change back to original way plus hdev_name? like: "hdev_name:xx:xx:xx:xx:xx:xx" diff -uprN a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c --- a/net/bluetooth/hci_conn.c 2009-04-18 19:45:21.000000000 +0800 +++ b/net/bluetooth/hci_conn.c 2009-04-18 19:45:15.000000000 +0800 @@ -247,6 +247,8 @@ struct hci_conn *hci_conn_add(struct hci if (hdev->notify) hdev->notify(hdev, HCI_NOTIFY_CONN_ADD); + hci_conn_add_sysfs(conn); + tasklet_enable(&hdev->tx_task); return conn; diff -uprN a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c --- a/net/bluetooth/hci_event.c 2009-04-18 19:45:28.000000000 +0800 +++ b/net/bluetooth/hci_event.c 2009-04-18 19:45:15.000000000 +0800 @@ -878,8 +878,6 @@ static inline void hci_conn_complete_evt } else conn->state = BT_CONNECTED; - hci_conn_add_sysfs(conn); - if (test_bit(HCI_AUTH, &hdev->flags)) conn->link_mode |= HCI_LM_AUTH; @@ -1656,8 +1654,6 @@ static inline void hci_sync_conn_complet if (!ev->status) { conn->handle = __le16_to_cpu(ev->handle); conn->state = BT_CONNECTED; - - hci_conn_add_sysfs(conn); } else conn->state = BT_CLOSED; diff -uprN a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c --- a/net/bluetooth/hci_sysfs.c 2009-04-18 19:45:35.000000000 +0800 +++ b/net/bluetooth/hci_sysfs.c 2009-04-18 19:45:15.000000000 +0800 @@ -101,6 +101,7 @@ static void add_conn(struct work_struct void hci_conn_add_sysfs(struct hci_conn *conn) { struct hci_dev *hdev = conn->hdev; + bdaddr_t *ba = &conn->dst; BT_DBG("conn %p", conn); @@ -108,7 +109,11 @@ void hci_conn_add_sysfs(struct hci_conn conn->dev.class = bt_class; conn->dev.parent = &hdev->dev; - dev_set_name(&conn->dev, "%s:%d", hdev->name, conn->handle); + dev_set_name(&conn->dev, + "%s:%2.2X%2.2X%2.2X%2.2X%2.2X%2.2X", + hdev->name, + ba->b[5], ba->b[4], ba->b[3], + ba->b[2], ba->b[1], ba->b[0]); dev_set_drvdata(&conn->dev, conn); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/