Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757042AbZDRTd4 (ORCPT ); Sat, 18 Apr 2009 15:33:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754118AbZDRTds (ORCPT ); Sat, 18 Apr 2009 15:33:48 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48457 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753947AbZDRTdr (ORCPT ); Sat, 18 Apr 2009 15:33:47 -0400 Date: Sat, 18 Apr 2009 12:28:51 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Sam Ravnborg cc: Russell King , takata@linux-m32r.org, Christoph Hellwig , Yoshinori Sato , linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm: use include/gen for mach-types.h In-Reply-To: <20090418181714.GA25786@uranus.ravnborg.org> Message-ID: References: <20090416150707.GA941@lst.de> <20090416164050.GB4850@uranus.ravnborg.org> <20090417221440.GA16791@uranus.ravnborg.org> <20090418101444.GA9768@flint.arm.linux.org.uk> <20090418181714.GA25786@uranus.ravnborg.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 911 Lines: 29 On Sat, 18 Apr 2009, Sam Ravnborg wrote: > > diff --git a/include/gen/.gitignore b/include/gen/.gitignore > new file mode 100644 > index 0000000..1e809fd > --- /dev/null > +++ b/include/gen/.gitignore > @@ -0,0 +1,2 @@ > +# mach-types.h is used by arm > +mach-types.h I think this is bad. The whole point of having 'include/gen' should be that _all_ files in that directory should be generated. So it should be include/.gitignore that just contains the pattern "gen/" and that's it. That said, I also dislike "gen" as a name. To me, it is more likely to mean "generation" in the sense of father/son/grandson than "generated". Why not spell it out? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/