Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbZDTF1f (ORCPT ); Mon, 20 Apr 2009 01:27:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753380AbZDTF1Z (ORCPT ); Mon, 20 Apr 2009 01:27:25 -0400 Received: from one.firstfloor.org ([213.235.205.2]:54056 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853AbZDTF1Y (ORCPT ); Mon, 20 Apr 2009 01:27:24 -0400 Date: Mon, 20 Apr 2009 07:30:40 +0200 From: Andi Kleen To: Kyle Moffett Cc: Huang Ying , Anthony Liguori , Avi Kivity , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andi Kleen Subject: Re: [PATCH -v2] Add MCE support to KVM Message-ID: <20090420053040.GT14687@one.firstfloor.org> References: <1239953345.6842.3.camel@yhuang-dev.sh.intel.com> <49E9F7BE.4090904@codemonkey.ws> <1240190385.6842.45.camel@yhuang-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1191 Lines: 25 > IMO the main reason to put this in kernel-space would be to make it > possible to automatically forward some MCE errors generated by the > real hardware (RAM ECC errors for example) down into the VM. Right > now I suppose you could do that with the patches to forward RAM-based > hard MCEs to userspace using SIGSEGV and handling the SIGSEGV in > userspace, but that seems more fragile to me. I think you refer to my hwpoison patches that generate SIGBUS? The event has to go through user space anyways. The code to generate the fake MCE from the SIGBUS is (or rather will be with current patch) in qemu. Normally the principle to process such errors as quickly as possible is sound though, although I'm not sure how much difference it makes. In theory it could be put into kernel too, but you would need a "in kernel signal handler" then, which would need quite some more changes. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/