Date: Mon, 20 Apr 2009 10:46:31 +0200
From: Ingo Molnar <mingo@elte.hu>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Oleg Nesterov <oleg@redhat.com>
Cc: Zhaolei <zhaolei@cn.fujitsu.com>, Frederic Weisbecker <fweisbec@gmail.com>,
       Steven Rostedt <rostedt@goodmis.org>, Tom Zanussi <tzanussi@gmail.com>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] ftrace, workqueuetrace: Make
	workqueuetracepoints use TRACE_EVENT macro
Message-ID: <20090420084631.GA32625@elte.hu>
References: <20090420103612.4B4E.A69D9226@jp.fujitsu.com> <47EF9F5C609F496FBBD423EA81A00920@zhaoleiwin> <20090420104734.4B51.A69D9226@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090420104734.4B51.A69D9226@jp.fujitsu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1220
Lines: 32


* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> OK.
> 
> thus, I recoomend to pending 2 and 3. and change 1 as Ingo 
> suggested. if not, reviewer might forgot this thread.

Ok - but even the original order of patches would be fine - as long 
as the end result is agreed on and is reached.

I've asked Frederic (the original author of the workqueue tracer 
plugin) to collect these patches into a topic branch in his tree. 
Once it's a complete story we can pull it into tip:tracing/core.

Oleg seemed not to disagree and Andrew is in hiding.

Andrew, Oleg: if you plan to make unhappy noises about this level of 
instrumentation in the workqueue code, please do it sooner rather 
than later, as there's quite some effort injected into this already. 
A tentative non-NAK now (patches are still being sorted out) and an 
Ack on the final topic tree from you (once we send it and if it's 
good) and general happiness would be the ideal outcome :)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/