Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbZDTIsk (ORCPT ); Mon, 20 Apr 2009 04:48:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754445AbZDTIsR (ORCPT ); Mon, 20 Apr 2009 04:48:17 -0400 Received: from mail.crca.org.au ([67.207.131.56]:48198 "EHLO crca.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbZDTIsQ (ORCPT ); Mon, 20 Apr 2009 04:48:16 -0400 X-Bogosity: Ham, spamicity=0.000000 Subject: Re: [PATCH] PM/Suspend: Introduce two new platform callbacks to avoid breakage (Re: 900af0d breaks some embedded suspend/resume) From: Nigel Cunningham Reply-To: ncunningham-lkml@crca.org.au To: Russell King Cc: "Rafael J. Wysocki" , Len Brown , Linux Kernel List , Linus Torvalds , pm list , ACPI Devel Maling List In-Reply-To: <20090420083523.GB16002@flint.arm.linux.org.uk> References: <20090417231009.GB6900@flint.arm.linux.org.uk> <200904181626.10388.rjw@sisk.pl> <20090418144132.GC7148@flint.arm.linux.org.uk> <200904182047.48009.rjw@sisk.pl> <1240183907.8867.22.camel@nigel-laptop> <20090420083523.GB16002@flint.arm.linux.org.uk> Content-Type: text/plain Date: Mon, 20 Apr 2009 18:48:27 +1000 Message-Id: <1240217307.8867.53.camel@nigel-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 33 Hi. On Mon, 2009-04-20 at 09:35 +0100, Russell King wrote: > On Mon, Apr 20, 2009 at 09:31:47AM +1000, Nigel Cunningham wrote: > > > } > > > > > > - if (suspend_ops->prepare) { > > > - error = suspend_ops->prepare(); > > > + if (suspend_ops->prepare_late) { > > > + error = suspend_ops->prepare_late(); > > > if (error) > > > goto Power_up_devices; > > > } > > > > Doesn't this invalidate testing that's already been done? Drivers > > implementing prepare() (arm omap1, pxa, omap2, s3c and powerpc mpc52xx > > and lite5200) are now going to have it called pre device_power_down. > > ... which is the way it has always been done prior to the change which > broke stuff. So this patch is putting the ordering back the way it was > which has been well proven to work on these platforms. > > So we're not invalidating any testing. Ah, okay. I didn't look at anything but current HEAD. :) Nigel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/