Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbZDTLIU (ORCPT ); Mon, 20 Apr 2009 07:08:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754512AbZDTLII (ORCPT ); Mon, 20 Apr 2009 07:08:08 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:41223 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbZDTLIF (ORCPT ); Mon, 20 Apr 2009 07:08:05 -0400 Date: Mon, 20 Apr 2009 05:08:04 -0600 From: Matthew Wilcox To: Hidetoshi Seto Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jesse Barnes Subject: Re: [PATCH 2/2] pci, msi: Define PCI_MSI_MASK_32/64 Message-ID: <20090420110803.GS1926@parisc-linux.org> References: <49EBD5F3.9090107@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49EBD5F3.9090107@jp.fujitsu.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 894 Lines: 23 On Mon, Apr 20, 2009 at 10:54:59AM +0900, Hidetoshi Seto wrote: > Impact: cleanup, improve readability > > Define PCI_MSI_MASK_32/64 for 32/64bit devices, instead of using > implicit offset (-4), "PCI_MSI_MASK_BIT - 4" and "PCI_MSI_MASK_BIT". > > Signed-off-by: Hidetoshi Seto > Cc: Jesse Barnes Yes, nice cleanup. Reviewed-by: Matthew Wilcox -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/