Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755351AbZDTMAU (ORCPT ); Mon, 20 Apr 2009 08:00:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755080AbZDTL76 (ORCPT ); Mon, 20 Apr 2009 07:59:58 -0400 Received: from mx2.redhat.com ([66.187.237.31]:48580 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755088AbZDTL75 (ORCPT ); Mon, 20 Apr 2009 07:59:57 -0400 Date: Mon, 20 Apr 2009 13:53:42 +0200 From: Stanislaw Gruszka To: Brice Goglin Cc: David Dillow , "linux-kernel@vger.kernel.org" , Linux Network Development list Subject: Re: [PATCH net-next] myri10ge: allow per-board firmware overriding Message-ID: <20090420135342.417f3ebd@dhcp-lab-109.englab.brq.redhat.com> In-Reply-To: <49EC4683.3060605@myri.com> References: <49E7239B.4000309@myri.com> <20090417095038.49b745bf@dhcp-lab-109.englab.brq.redhat.com> <49EA1DAC.1000602@myri.com> <1240102617.5342.6.camel@obelisk.thedillows.org> <1240108599.5342.11.camel@obelisk.thedillows.org> <20090420114041.37c7fa7b@dhcp-lab-109.englab.brq.redhat.com> <49EC4683.3060605@myri.com> Organization: RedHat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 33 On Mon, 20 Apr 2009 11:55:15 +0200 Brice Goglin wrote: > Stanislaw Gruszka wrote: > > Providing module_param_id would address this issues, but I have some concerns > > before doing it: > > > > - device have to access ID (like serial no) before initialization (at least > > before driver will need parameter) > > - why nobody already done it - perhaps such thing would be totally useless > > > > Per-nic module parameters are used in some Intel NIC drivers but it's > not considered a very good solution in the general case: > > http://kerneltrap.org/index.php?q=mailarchive/linux-netdev/2008/10/24/3801824/thread > > But again, when talking about changing the NIC firmware, ethtool and > friends are not that easy. I agree that device parameters, which are not needed during initialization or can be changed at runtime shall not be module parameters. I agree also that some parameters are needed during startup when driver loads and are driver specific. For these modules parameters shall be used. Firmware is one example, I think we have others. Cheers Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/