Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbZDTSWB (ORCPT ); Mon, 20 Apr 2009 14:22:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754617AbZDTSVj (ORCPT ); Mon, 20 Apr 2009 14:21:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:61242 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754818AbZDTSVi (ORCPT ); Mon, 20 Apr 2009 14:21:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.40,218,1239001200"; d="scan'208";a="449596617" Message-ID: <49ECBD31.9010607@intel.com> Date: Mon, 20 Apr 2009 11:21:37 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Ingo Molnar CC: Brian Maly , Andrew Morton , "linux-kernel@vger.kernel.org" , "dannf@hp.com" , "Huang, Ying" Subject: Re: [PATCH] rtc: add x86 support for rtc-efi References: <49DA40B9.2060804@redhat.com> <49DA817E.8040705@intel.com> <49DA8875.5050009@redhat.com> <20090409161803.f79c0b64.akpm@linux-foundation.org> <20090410135102.GB24809@elte.hu> <49ECADAB.4020609@redhat.com> <20090420172045.GA17887@elte.hu> In-Reply-To: <20090420172045.GA17887@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1163 Lines: 30 Ingo Molnar wrote: > * Brian Maly wrote: > >>> Hm, it would be nice to first unify the relevant bits of >>> arch/x86/kernel/time_{32|64}.c into arch/x86/kernel/time.c, and >>> then we can apply such patches without duplicative effects. >> Ingo, >> >> Are you OK with consolidating this into arch/x86/kernel/rtc.c as >> Huang Ying had suggested? This seems like the most logical place >> for the rtc-efi init to happen, but your suggestion to consolidate >> this into arch/x86/kernel.time.c may have advantages that I am not >> aware of. Anyway, I would appreciate any insight/opinions on this >> if you have any. Thanks. > > Yes, that indeed sounds like an even better place for it. > Furthermore, the EFI RTC code probably should be in its own file. In fact, arch/x86/kernel really could use more subdirectories; at least the EFI and UV-specific code should be be moved out. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/