Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756556AbZDTUOP (ORCPT ); Mon, 20 Apr 2009 16:14:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755483AbZDTUN6 (ORCPT ); Mon, 20 Apr 2009 16:13:58 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:47413 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755301AbZDTUN5 (ORCPT ); Mon, 20 Apr 2009 16:13:57 -0400 Date: Mon, 20 Apr 2009 13:04:12 -0700 From: Andrew Morton To: Pavel Machek Cc: torvalds@linux-foundation.org, jens.axboe@oracle.com, alan-jenkins@tuffmail.co.uk, rjw@sisk.pl, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org Subject: Re: [Bug #13058] First hibernation attempt fails Message-Id: <20090420130412.bc337673.akpm@linux-foundation.org> In-Reply-To: <20090420195306.GA3299@elf.ucw.cz> References: <20090417063007.GB4593@kernel.dk> <49E83DC4.8040207@tuffmail.co.uk> <20090417091321.GP4593@kernel.dk> <20090407080632.GG1408@ucw.cz> <20090420122044.7ea6cc15.akpm@linux-foundation.org> <20090420195306.GA3299@elf.ucw.cz> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1855 Lines: 49 On Mon, 20 Apr 2009 21:53:06 +0200 Pavel Machek wrote: > > Remind me: why can't we just allocate N pages at suspend-time? > > We need half of memory free. The reason we can't "just allocate" is > probably OOM killer; but my memories are quite weak :-(. hm. You'd think that with out splendid range of __GFP_foo falgs, there would be some combo which would suit this requirement but I can't immediately spot one. We can always add another I guess. Something like... diff -puN mm/page_alloc.c~a mm/page_alloc.c --- a/mm/page_alloc.c~a +++ a/mm/page_alloc.c @@ -1620,7 +1620,8 @@ nofail_alloc: } /* The OOM killer will not help higher order allocs so fail */ - if (order > PAGE_ALLOC_COSTLY_ORDER) { + if (order > PAGE_ALLOC_COSTLY_ORDER || + (gfp_mask & __GFP_NO_OOM_KILL)) { clear_zonelist_oom(zonelist, gfp_mask); goto nopage; } diff -puN include/linux/gfp.h~a include/linux/gfp.h --- a/include/linux/gfp.h~a +++ a/include/linux/gfp.h @@ -51,8 +51,9 @@ struct vm_area_struct; #define __GFP_THISNODE ((__force gfp_t)0x40000u)/* No fallback, no policies */ #define __GFP_RECLAIMABLE ((__force gfp_t)0x80000u) /* Page is reclaimable */ #define __GFP_MOVABLE ((__force gfp_t)0x100000u) /* Page is movable */ +#define __GFP_NO_OOM_KILL ((__force gfp_t)0x200000u) /* Don't invoke out_of_memory() */ -#define __GFP_BITS_SHIFT 21 /* Room for 21 __GFP_FOO bits */ +#define __GFP_BITS_SHIFT 22 /* Number of__GFP_FOO bits */ #define __GFP_BITS_MASK ((__force gfp_t)((1 << __GFP_BITS_SHIFT) - 1)) /* This equals 0, but use constants in case they ever change */ _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/