Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755243AbZDTXpi (ORCPT ); Mon, 20 Apr 2009 19:45:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754758AbZDTXpQ (ORCPT ); Mon, 20 Apr 2009 19:45:16 -0400 Received: from lon1-post-1.mail.demon.net ([195.173.77.148]:34145 "EHLO lon1-post-1.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbZDTXpO (ORCPT ); Mon, 20 Apr 2009 19:45:14 -0400 Message-ID: <49ED090F.4050503@lougher.demon.co.uk> Date: Tue, 21 Apr 2009 00:45:19 +0100 From: Phillip Lougher User-Agent: Thunderbird 2.0.0.18 (X11/20081125) MIME-Version: 1.0 To: Geert Uytterhoeven CC: Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH/RFC] crypto: compress - Return produced bytes in crypto_{,de}compress_{update,final}() (was: Re: [PATCH/RFC] crypto: compress - Add comp_request.total_out References: <1235569394-15217-3-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-4-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-5-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-6-git-send-email-Geert.Uytterhoeven@sonycom.com> <1235569394-15217-7-git-send-email-Geert.Uytterhoeven@sonycom.com> <20090307104637.GB8731@gondor.apana.org.au> <49B36A18.5030506@lougher.demon.co.uk> <20090420060313.GA891@gondor.apana.org.au> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1571 Lines: 41 Geert Uytterhoeven wrote: > On Mon, 20 Apr 2009, Herbert Xu wrote: >> On Tue, Mar 24, 2009 at 05:33:01PM +0100, Geert Uytterhoeven wrote: >>> Here's an alternative patch, which does exactly that. >>> Phillip, what do you think? >>> >>> Thanks for your comments! >>> >>> >From be7d630f96a85d3ce48716b8e328563ba217647b Mon Sep 17 00:00:00 2001 >>> From: Geert Uytterhoeven >>> Date: Tue, 24 Mar 2009 17:19:05 +0100 >>> Subject: [PATCH] crypto: compress - Return produced bytes in crypto_{,de}compress_{update,final}() >>> >>> If crypto_{,de}compress_{update,final}() succeed, return the actual number of >>> bytes produced instead of zero, so their users don't have to calculate that >>> theirselves. >>> >>> Signed-off-by: Geert Uytterhoeven >> I certainly prefer this version over the other one? Do you want to >> submit crypto API portion of this? > > If you think I should submit it now, I can do it. But I'm still waiting for > Phillip's comments. > I think I said they looked OK to me. But, I want to do performance tests to see if there's any performance degradation over vanilla zlib, and see if they cope gracefully with corrupted filesystems. Herbert, are the other cryto API patches in linux-next (or any other git repository)? Thanks Phillip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/