Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755361AbZDUAC4 (ORCPT ); Mon, 20 Apr 2009 20:02:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752646AbZDUACs (ORCPT ); Mon, 20 Apr 2009 20:02:48 -0400 Received: from anchor-post-3.mail.demon.net ([195.173.77.134]:41515 "EHLO anchor-post-3.mail.demon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbZDUACr (ORCPT ); Mon, 20 Apr 2009 20:02:47 -0400 Message-ID: <49ED0D2C.40306@lougher.demon.co.uk> Date: Tue, 21 Apr 2009 01:02:52 +0100 From: Phillip Lougher User-Agent: Thunderbird 2.0.0.18 (X11/20081125) MIME-Version: 1.0 To: Geert Uytterhoeven CC: squashfs-devel@lists.sourceforge.net, linux-kernel , Doug Chapman Subject: Re: [Squashfs-devel] [PATCH] squashfs broken when pageszie > blocksize References: <1239652637.1127.10.camel@oberon> <49E3C209.5030705@lougher.demon.co.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 32 Geert Uytterhoeven wrote: > A quick grep on PAGE_{SIZE,SHIFT} in asm/page.h shows: > > ia64, mips, sh: 4/8/16/64 KiB > parisc: 4/16/64 KiB > alpha, cris: 8 KiB > powerpc: 4/16/64/256 KiB > >> For completeness there should also be a mount time check that >> the block size used in the Squashfs filesystem is at least as >> large as the pagesize. This doesn't matter for metadata >> (size 8192), but does matter for data blocks, because Squashfs >> read_page doesn't handle block_size < pagesize. >> >> Squashfs read_page used to handle block_size < pagesize but I >> removed that code when I removed filesystem support for block_sizes >> < 4K. If ia64 users (or any other architecture with larger than >> 4K pagesizes) want to use Squashfs filesystems with blocksizes less >> than their pagesize, then I can put that code back in. > > So I think it's a good idea to resurrect that code... > Yes, something else to add to my ASAP TODO list. Phillip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/