Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988AbZDUGiT (ORCPT ); Tue, 21 Apr 2009 02:38:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751964AbZDUGiD (ORCPT ); Tue, 21 Apr 2009 02:38:03 -0400 Received: from mga09.intel.com ([134.134.136.24]:32212 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473AbZDUGiB convert rfc822-to-8bit (ORCPT ); Tue, 21 Apr 2009 02:38:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.40,222,1239001200"; d="scan'208";a="508343507" From: "Han, Weidong" To: "Siddha, Suresh B" , "mingo@elte.hu" , "hpa@zytor.com" , "tglx@linutronix.de" CC: "linux-kernel@vger.kernel.org" , "dwmw2@infradead.org" Date: Tue, 21 Apr 2009 14:37:21 +0800 Subject: RE: [patch 4/5] x2apic, IR: remove reinit_intr_remapped_IO_APIC() Thread-Topic: [patch 4/5] x2apic, IR: remove reinit_intr_remapped_IO_APIC() Thread-Index: AcnB9MOdc7tQKGreRViG3dvnCeLzrgAU2DfA Message-ID: <715D42877B251141A38726ABF5CABF2C01A6B7F9FC@pdsmsx503.ccr.corp.intel.com> References: <20090420200450.128993000@linux-os.sc.intel.com> <20090420200450.552359000@linux-os.sc.intel.com> In-Reply-To: <20090420200450.552359000@linux-os.sc.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2087 Lines: 52 Siddha, Suresh B wrote: > When interrupt-remapping is enabled, We are relying on > setup_IO_APIC_irqs() > to configure remapped entries in the IO-APIC, which comes little bit > later after enabling interrupt-remapping. > > Meanwhile, Restore of old io-apic entries after enabling > interrupt-remapping will not make the interrupts through io-apic > functional anyway. > > So remove unnecessary reinit_intr_remapped_IO_APIC(). > > Signed-off-by: Suresh Siddha > Cc: Weidong Han > --- > > Index: tip/arch/x86/include/asm/io_apic.h > =================================================================== > --- tip.orig/arch/x86/include/asm/io_apic.h > +++ tip/arch/x86/include/asm/io_apic.h > @@ -166,8 +166,6 @@ extern void free_ioapic_entries(struct I > extern int save_IO_APIC_setup(struct IO_APIC_route_entry > **ioapic_entries); extern void mask_IO_APIC_setup(struct > IO_APIC_route_entry **ioapic_entries); extern int > restore_IO_APIC_setup(struct IO_APIC_route_entry **ioapic_entries); > -extern void reinit_intr_remapped_IO_APIC(int intr_remapping, > - struct IO_APIC_route_entry **ioapic_entries); > > extern void probe_nr_irqs_gsi(void); > > Index: tip/arch/x86/kernel/apic/apic.c > =================================================================== > --- tip.orig/arch/x86/kernel/apic/apic.c > +++ tip/arch/x86/kernel/apic/apic.c > @@ -1416,8 +1416,6 @@ end_restore: > * IR enabling failed > */ > restore_IO_APIC_setup(ioapic_entries); > - else > - reinit_intr_remapped_IO_APIC(x2apic_preenabled, ioapic_entries); Whether IR enabling succeeds or fails, it always needs to restore old IOAPIC entries. Due to removing reinit_intr_remapped_IO_APIC here, it needs to also remove the "if (ret)" before restore_IO_APIC_setup(ioapic_entries); Regards, Weidong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/